[PR #6869] [MERGED] bugfix: fnettrace-icmp: fix uninitialized vars (cppcheck) #6209

New issue

Closed

opened 2026-05-05 10:52:45 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:52:45 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/6869
Author: @kmk3
Created: 8/18/2025
Status: ✅ Merged
Merged: 8/18/2025
Merged by: @netblue30

Base: master ← Head: cppcheck-fix-var-init

📝 Commits (1)

e205ed3 bugfix: fnettrace-icmp: fix uninitialized vars (cppcheck)

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/fnettrace-icmp/main.c (+2 -2)

📄 Description

These warnings break CI when using ubuntu-24.04:

$ cppcheck --version
Cppcheck 2.13.0
$ make cppcheck
cppcheck -q -j '4' --force --error-exitcode=1 --enable=warning,performance --max-ctu-depth=40 \
  -i src/firejail/checkcfg.c -i src/firejail/main.c .
src/fnettrace-icmp/main.c:116:3: warning: Uninitialized variable: type_ptr [uninitvar]
  type_ptr,
  ^
src/fnettrace-icmp/main.c:90:19: note: Assignment 'type_ptr=type_number', assigned value is <Uninit>
 char *type_ptr = type_number;
                  ^
src/fnettrace-icmp/main.c:91:11: note: Assuming condition is true
 if (type < 19)
          ^
src/fnettrace-icmp/main.c:116:3: note: Uninitialized variable: type_ptr
  type_ptr,
  ^
src/fnettrace-icmp/main.c:117:3: warning: Uninitialized variable: code_ptr [uninitvar]
  code_ptr);
  ^
src/fnettrace-icmp/main.c:97:19: note: Assignment 'code_ptr=code_number', assigned value is <Uninit>
 char *code_ptr = code_number;
                  ^
src/fnettrace-icmp/main.c:98:15: note: Assuming condition is true
 if (type ==3 && code < 16)
              ^
src/fnettrace-icmp/main.c:117:3: note: Uninitialized variable: code_ptr
  code_ptr);
  ^
make: *** [Makefile:379: cppcheck] Error 1

Kind of relates to #6868.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/6869 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 8/18/2025 **Status:** ✅ Merged **Merged:** 8/18/2025 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `cppcheck-fix-var-init` --- ### 📝 Commits (1) - [`e205ed3`](https://github.com/netblue30/firejail/commit/e205ed32e97d41e74401ecbba62aeb7ee265ab2d) bugfix: fnettrace-icmp: fix uninitialized vars (cppcheck) ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/fnettrace-icmp/main.c` (+2 -2) </details> ### 📄 Description These warnings break CI when using `ubuntu-24.04`: $ cppcheck --version Cppcheck 2.13.0 $ make cppcheck cppcheck -q -j '4' --force --error-exitcode=1 --enable=warning,performance --max-ctu-depth=40 \ -i src/firejail/checkcfg.c -i src/firejail/main.c . src/fnettrace-icmp/main.c:116:3: warning: Uninitialized variable: type_ptr [uninitvar] type_ptr, ^ src/fnettrace-icmp/main.c:90:19: note: Assignment 'type_ptr=type_number', assigned value is <Uninit> char *type_ptr = type_number; ^ src/fnettrace-icmp/main.c:91:11: note: Assuming condition is true if (type < 19) ^ src/fnettrace-icmp/main.c:116:3: note: Uninitialized variable: type_ptr type_ptr, ^ src/fnettrace-icmp/main.c:117:3: warning: Uninitialized variable: code_ptr [uninitvar] code_ptr); ^ src/fnettrace-icmp/main.c:97:19: note: Assignment 'code_ptr=code_number', assigned value is <Uninit> char *code_ptr = code_number; ^ src/fnettrace-icmp/main.c:98:15: note: Assuming condition is true if (type ==3 && code < 16) ^ src/fnettrace-icmp/main.c:117:3: note: Uninitialized variable: code_ptr code_ptr); ^ make: *** [Makefile:379: cppcheck] Error 1 Kind of relates to #6868. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:52:45 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#6209

No description provided.

Rows
Columns