[PR #6674] [MERGED] bugfix: firecfg: check full .desktop filename in check_profile() #6115

New issue

Closed

opened 2026-05-05 10:51:00 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:51:00 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/6674
Author: @kmk3
Created: 3/1/2025
Status: ✅ Merged
Merged: 3/4/2025
Merged by: @kmk3

Base: master ← Head: firecfg-fix-full-desktop

📝 Commits (1)

7f31fbf bugfix: firecfg: check full filename in check_profile()

📊 Changes

1 file changed (+10 additions, -3 deletions)

View changed files

📝 src/firecfg/desktop_files.c (+10 -3)

📄 Description

Currently, firecfg only checks the last word in .desktop files when
trying to match them to an existing profile. For example:

org.gnome.gedit.desktop -> gedit.desktop
org.gnome.seahorse.Application.desktop -> Application.desktop

This works in the former case where there is an exact match of the last
word on each side (gedit.desktop and gedit.profile), but not in the
latter case (Application.desktop and seahorse.profile).

So make firecfg also check the full filename of the .desktop file, to
make it easier to create redirect profiles that match the full name of
the .desktop files. For example:

org.gnome.seahorse.Application.desktop ->
org.gnome.seahorse.Application.profile (which itself then redirects
to seahorse.profile)

Related commits:

a6341b904 ("disable DBus activation in firecfg", 2017-09-25)
3e69deba3 ("fix firecfg", 2017-09-25)
bd9761508 ("Temp fix firecfg (#2634)", 2019-04-02)

Relates to #2624 #6658.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/6674 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 3/1/2025 **Status:** ✅ Merged **Merged:** 3/4/2025 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `firecfg-fix-full-desktop` --- ### 📝 Commits (1) - [`7f31fbf`](https://github.com/netblue30/firejail/commit/7f31fbf03e0f4c516f7a5d7ee7b7eea724a1cc6c) bugfix: firecfg: check full filename in check_profile() ### 📊 Changes **1 file changed** (+10 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/firecfg/desktop_files.c` (+10 -3) </details> ### 📄 Description Currently, firecfg only checks the last word in .desktop files when trying to match them to an existing profile. For example: * `org.gnome.gedit.desktop` -> `gedit.desktop` * `org.gnome.seahorse.Application.desktop` -> `Application.desktop` This works in the former case where there is an exact match of the last word on each side (`gedit.desktop` and `gedit.profile`), but not in the latter case (`Application.desktop` and `seahorse.profile`). So make firecfg also check the full filename of the .desktop file, to make it easier to create redirect profiles that match the full name of the .desktop files. For example: * `org.gnome.seahorse.Application.desktop` -> `org.gnome.seahorse.Application.profile` (which itself then redirects to `seahorse.profile`) Related commits: * a6341b904 ("disable DBus activation in firecfg", 2017-09-25) * 3e69deba3 ("fix firecfg", 2017-09-25) * bd9761508 ("Temp fix firecfg (#2634)", 2019-04-02) Relates to #2624 #6658. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:51:00 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#6115

No description provided.

Rows
Columns