[PR #6620] [MERGED] build: rename print-version target to installcheck #6093

New issue

Closed

opened 2026-05-05 10:50:37 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:50:37 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/6620
Author: @kmk3
Created: 1/16/2025
Status: ✅ Merged
Merged: 1/18/2025
Merged by: @kmk3

Base: master ← Head: build-rename-print-version

📝 Commits (1)

584950c build: rename print-version target to installcheck

📊 Changes

6 files changed (+24 additions, -24 deletions)

View changed files

📝 .github/workflows/build-extra.yml (+2 -2)
📝 .github/workflows/build.yml (+2 -2)
📝 .github/workflows/test.yml (+10 -10)
📝 .gitlab-ci.yml (+7 -7)
📝 Makefile (+2 -2)
📝 gcov.sh (+1 -1)

📄 Description

To make it consistent with the standard GNU make targets.

From the manual of GNU Make (version 4.4.1-2):

'installcheck'
Perform installation tests (if any). The user must build and
install the program before running the tests. You should not
assume that '$(bindir)' is in the search path.

Commands used to search and replace:

$ git grep -Ilz print-version |
  xargs -0 -I '{}' sh -c "printf '%s\n' \"\$(sed \
    's/print-version/installcheck/g' '{}')\" >'{}'"
$ git grep -Ilz 'print version' .github/workflows |
  xargs -0 -I '{}' sh -c "printf '%s\n' \"\$(sed \
    's/print version/make installcheck/g' '{}')\" >'{}'"

Added on commit c9531d95e ("build: add print-version target and use in
CI", 2024-02-22) / #6230.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/6620 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 1/16/2025 **Status:** ✅ Merged **Merged:** 1/18/2025 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `build-rename-print-version` --- ### 📝 Commits (1) - [`584950c`](https://github.com/netblue30/firejail/commit/584950c0d1a597b3b2544a91426ff608fd637d8d) build: rename print-version target to installcheck ### 📊 Changes **6 files changed** (+24 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build-extra.yml` (+2 -2) 📝 `.github/workflows/build.yml` (+2 -2) 📝 `.github/workflows/test.yml` (+10 -10) 📝 `.gitlab-ci.yml` (+7 -7) 📝 `Makefile` (+2 -2) 📝 `gcov.sh` (+1 -1) </details> ### 📄 Description To make it consistent with the standard GNU make targets. From the manual of GNU Make (version 4.4.1-2): > 'installcheck' > Perform installation tests (if any). The user must build and > install the program before running the tests. You should not > assume that '$(bindir)' is in the search path. Commands used to search and replace: $ git grep -Ilz print-version | xargs -0 -I '{}' sh -c "printf '%s\n' \"\$(sed \ 's/print-version/installcheck/g' '{}')\" >'{}'" $ git grep -Ilz 'print version' .github/workflows | xargs -0 -I '{}' sh -c "printf '%s\n' \"\$(sed \ 's/print version/make installcheck/g' '{}')\" >'{}'" Added on commit c9531d95e ("build: add print-version target and use in CI", 2024-02-22) / #6230. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:50:38 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#6093

No description provided.

Rows
Columns