[PR #6594] [MERGED] build: sort.py: quote diff lines #6086

Closed
opened 2026-05-05 10:50:27 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/6594
Author: @kmk3
Created: 12/29/2024
Status: Merged
Merged: 12/29/2024
Merged by: @kmk3

Base: masterHead: build-sort-py-quote-diff


📝 Commits (1)

  • 0b6e9cb build: sort.py: quote diff lines

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 contrib/sort.py (+2 -2)

📄 Description

To make it clearer when only whitespace was fixed on a given line.

Before:

$ printf 'private-bin a,b \n' >foo.profile
$ ./contrib/sort.py -n foo.profile
sort.py: checking 1 profile(s)...
foo.profile:1:-private-bin a,b
foo.profile:1:+private-bin a,b

After:

$ printf 'private-bin a,b \n' >foo.profile
$ ./contrib/sort.py -n foo.profile
sort.py: checking 1 profile(s)...
foo.profile:1:-'private-bin a,b '
foo.profile:1:+'private-bin a,b'

See commit 53ff8e0ad ("build: sort.py: strip trailing whitespace in all
lines", 2024-11-26) / PR #6556.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/6594 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 12/29/2024 **Status:** ✅ Merged **Merged:** 12/29/2024 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `build-sort-py-quote-diff` --- ### 📝 Commits (1) - [`0b6e9cb`](https://github.com/netblue30/firejail/commit/0b6e9cbd7bd57685169bcefc4225bf6132bb3a5b) build: sort.py: quote diff lines ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `contrib/sort.py` (+2 -2) </details> ### 📄 Description To make it clearer when only whitespace was fixed on a given line. Before: $ printf 'private-bin a,b \n' >foo.profile $ ./contrib/sort.py -n foo.profile sort.py: checking 1 profile(s)... foo.profile:1:-private-bin a,b foo.profile:1:+private-bin a,b After: $ printf 'private-bin a,b \n' >foo.profile $ ./contrib/sort.py -n foo.profile sort.py: checking 1 profile(s)... foo.profile:1:-'private-bin a,b ' foo.profile:1:+'private-bin a,b' See commit 53ff8e0ad ("build: sort.py: strip trailing whitespace in all lines", 2024-11-26) / PR #6556. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 10:50:27 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#6086
No description provided.