[PR #6415] [MERGED] bugfix: firemon: skip coredump if unsupported #6003

New issue

Closed

opened 2026-05-05 10:48:55 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:48:55 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/6415
Author: @kmk3
Created: 7/24/2024
Status: ✅ Merged
Merged: 7/25/2024
Merged by: @kmk3

Base: master ← Head: bugfix-firemon-coredump

📝 Commits (1)

10c4558 bugfix: firemon: skip coredump if unsupported

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 src/firemon/procevent.c (+3 -0)

📄 Description

The coredump-related code fails to build on Linux kernel version 3.8 as
apparently it only exists on Linux since version 3.10:

docker run --platform linux/386 --rm -it satmandu/crewbuild:386
[...]
./configure && make
[...]
gcc -ggdb -O2 -DVERSION='"0.9.73"' [...] -march=i686  -c ../../src/firemon/procevent.c -o ../../src/firemon/procevent.o
../../src/firemon/procevent.c: In function ‘procevent_monitor’:
../../src/firemon/procevent.c:399:38: error: ‘PROC_EVENT_COREDUMP’ undeclared (first use in this function); did you mean ‘PROC_EVENT_COMM’?
  399 |                                 case PROC_EVENT_COREDUMP:
      |                                      ^~~~~~~~~~~~~~~~~~~
      |                                      PROC_EVENT_COMM
../../src/firemon/procevent.c:399:38: note: each undeclared identifier is reported only once for each function it appears in
../../src/firemon/procevent.c:400:66: error: ‘union <anonymous>’ has no member named ‘coredump’
  400 |                                         pid = proc_ev->event_data.coredump.process_tgid;
      |                                                                  ^
make[1]: *** [../../src/prog.mk:25: ../../src/firemon/procevent.o] Error 1
make[1]: Leaving directory '/home/chronos/user/firejail/src/firemon'
make: *** [Makefile:72: src/firemon/firemon] Error 2

Environment: gcc 14.1.0, glibc 2.23 and linuxheaders 3.8 on ChromeOS
M58.

Misc: @Zopolis4 also reports that "All i686 chromebooks have a kernel
version of 3.8".

This amends commit e11949a71 ("add support for comm, coredump, and prctl
procevents in firemon", 2024-04-30).

Fixes #6414.

Reported-by: @Zopolis4

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/6415 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 7/24/2024 **Status:** ✅ Merged **Merged:** 7/25/2024 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `bugfix-firemon-coredump` --- ### 📝 Commits (1) - [`10c4558`](https://github.com/netblue30/firejail/commit/10c4558d38bdeeabcb14047d1b529dbe5e035672) bugfix: firemon: skip coredump if unsupported ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/firemon/procevent.c` (+3 -0) </details> ### 📄 Description The coredump-related code fails to build on Linux kernel version 3.8 as apparently it only exists on Linux since version 3.10: docker run --platform linux/386 --rm -it satmandu/crewbuild:386 [...] ./configure && make [...] gcc -ggdb -O2 -DVERSION='"0.9.73"' [...] -march=i686 -c ../../src/firemon/procevent.c -o ../../src/firemon/procevent.o ../../src/firemon/procevent.c: In function ‘procevent_monitor’: ../../src/firemon/procevent.c:399:38: error: ‘PROC_EVENT_COREDUMP’ undeclared (first use in this function); did you mean ‘PROC_EVENT_COMM’? 399 | case PROC_EVENT_COREDUMP: | ^~~~~~~~~~~~~~~~~~~ | PROC_EVENT_COMM ../../src/firemon/procevent.c:399:38: note: each undeclared identifier is reported only once for each function it appears in ../../src/firemon/procevent.c:400:66: error: ‘union <anonymous>’ has no member named ‘coredump’ 400 | pid = proc_ev->event_data.coredump.process_tgid; | ^ make[1]: *** [../../src/prog.mk:25: ../../src/firemon/procevent.o] Error 1 make[1]: Leaving directory '/home/chronos/user/firejail/src/firemon' make: *** [Makefile:72: src/firemon/firemon] Error 2 Environment: gcc 14.1.0, glibc 2.23 and linuxheaders 3.8 on ChromeOS M58. Misc: @Zopolis4 also reports that "All i686 chromebooks have a kernel version of 3.8". This amends commit e11949a71 ("add support for comm, coredump, and prctl procevents in firemon", 2024-04-30). Fixes #6414. Reported-by: @Zopolis4 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:48:55 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#6003

No description provided.

Rows
Columns