[PR #6354] [MERGED] build: allow overriding common tools #5977

New issue

Closed

opened 2026-05-05 10:48:28 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:48:28 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/6354
Author: @kmk3
Created: 5/24/2024
Status: ✅ Merged
Merged: 5/29/2024
Merged by: @kmk3

Base: master ← Head: build-tool-vars

📝 Commits (2)

5e2f4c3 build: define CC/GAWK if undefined
fb11081 build: allow overriding common tools

📊 Changes

10 files changed (+265 additions, -90 deletions)

View changed files

📝 Makefile (+78 -71)
📝 config.mk.in (+3 -0)
📝 configure (+144 -0)
📝 configure.ac (+3 -0)
📝 src/bash_completion/Makefile (+5 -2)
📝 src/man/Makefile (+7 -3)
📝 src/prog.mk (+4 -1)
📝 src/so.mk (+4 -1)
📝 src/zsh_completion/Makefile (+5 -2)
📝 test/Makefile (+12 -10)

📄 Description

Tools:

gzip
install
rm
strip
tar

For the programs not checked in configure.ac:

From the manual of GNU Autoconf (version 2.71):

If you use AC_PROG_INSTALL, you must include install-sh in your
distribution

So set install just in the Makefile. Use $(RM) to ensure that -f
is always used and to make it easier to spot when -r is used.

See commit 93d623fdf ("build: allow overriding certain tools",
2024-02-23) / PR #6222.

This is a follow-up to #6342.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/6354 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 5/24/2024 **Status:** ✅ Merged **Merged:** 5/29/2024 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `build-tool-vars` --- ### 📝 Commits (2) - [`5e2f4c3`](https://github.com/netblue30/firejail/commit/5e2f4c36629ede58c3bb42111fdb3355c1317bcd) build: define CC/GAWK if undefined - [`fb11081`](https://github.com/netblue30/firejail/commit/fb11081becb80d681c2c8ab61125b42b12961314) build: allow overriding common tools ### 📊 Changes **10 files changed** (+265 additions, -90 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+78 -71) 📝 `config.mk.in` (+3 -0) 📝 `configure` (+144 -0) 📝 `configure.ac` (+3 -0) 📝 `src/bash_completion/Makefile` (+5 -2) 📝 `src/man/Makefile` (+7 -3) 📝 `src/prog.mk` (+4 -1) 📝 `src/so.mk` (+4 -1) 📝 `src/zsh_completion/Makefile` (+5 -2) 📝 `test/Makefile` (+12 -10) </details> ### 📄 Description Tools: * gzip * install * rm * strip * tar For the programs not checked in configure.ac: From the manual of GNU Autoconf (version 2.71): > If you use `AC_PROG_INSTALL`, you must include `install-sh` in your > distribution So set `install` just in the Makefile. Use `$(RM)` to ensure that `-f` is always used and to make it easier to spot when `-r` is used. See commit 93d623fdf ("build: allow overriding certain tools", 2024-02-23) / PR #6222. This is a follow-up to #6342. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:48:28 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5977

No description provided.

Rows
Columns