[PR #6339] [MERGED] build: sort.py: use -i by default and add -n #5968

Closed
opened 2026-05-05 10:48:17 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/6339
Author: @kmk3
Created: 5/13/2024
Status: Merged
Merged: 5/20/2024
Merged by: @kmk3

Base: masterHead: build-sort-py-n


📝 Commits (2)

  • b177ec0 build: sort.py: use -i by default and add -n
  • a6d2119 build: sort.py: support "--" and fail on unknown option

📊 Changes

1 file changed (+24 additions, -10 deletions)

View changed files

📝 contrib/sort.py (+24 -10)

📄 Description

Overwrite in-place by default (-i) and add -n to override it.

This restores the previous default behavior (from 0.9.72), for the sake
of being consistent with all previous versions and because it's more
likely to be the desired behavior in most cases.

This amends commit aa08aa132 ("build: sort.py: add and require -i to
edit in-place (#6290)", 2024-03-25).

  • build: sort.py: support "--" and fail on unknown option

Support "--" to end options and fail if an unknown option is given.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/6339 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 5/13/2024 **Status:** ✅ Merged **Merged:** 5/20/2024 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `build-sort-py-n` --- ### 📝 Commits (2) - [`b177ec0`](https://github.com/netblue30/firejail/commit/b177ec0552e6180e9ff7111ef0793f783791c4a2) build: sort.py: use -i by default and add -n - [`a6d2119`](https://github.com/netblue30/firejail/commit/a6d2119ee67178773dddf79a3275ae3b17becb69) build: sort.py: support "--" and fail on unknown option ### 📊 Changes **1 file changed** (+24 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `contrib/sort.py` (+24 -10) </details> ### 📄 Description Overwrite in-place by default (`-i`) and add `-n` to override it. This restores the previous default behavior (from 0.9.72), for the sake of being consistent with all previous versions and because it's more likely to be the desired behavior in most cases. This amends commit aa08aa132 ("build: sort.py: add and require -i to edit in-place (#6290)", 2024-03-25). * build: sort.py: support "--" and fail on unknown option Support "--" to end options and fail if an unknown option is given. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 10:48:17 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5968
No description provided.