[PR #6290] [MERGED] build: sort.py: add and require -i to edit in-place #5934

Closed
opened 2026-05-05 10:47:38 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/6290
Author: @kmk3
Created: 3/24/2024
Status: Merged
Merged: 3/25/2024
Merged by: @kmk3

Base: masterHead: build-sort-py-i


📝 Commits (1)

  • f7c0502 build: sort.py: add and require -i to edit in-place

📊 Changes

1 file changed (+22 additions, -14 deletions)

View changed files

📝 contrib/sort.py (+22 -14)

📄 Description

Similarly to sed -i and perl -i.

This allows checking if sort.py correctly sorts the relevant lines in a
profile without having to overwrite it, which makes debugging and
testing easier (for example, in #6261).

Note: If it finds items that are not sorted, it still sorts them, prints
the diff and returns an error.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/6290 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 3/24/2024 **Status:** ✅ Merged **Merged:** 3/25/2024 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `build-sort-py-i` --- ### 📝 Commits (1) - [`f7c0502`](https://github.com/netblue30/firejail/commit/f7c0502900d6217fb10e6e60cbb03f87d3236a3f) build: sort.py: add and require -i to edit in-place ### 📊 Changes **1 file changed** (+22 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `contrib/sort.py` (+22 -14) </details> ### 📄 Description Similarly to `sed -i` and `perl -i`. This allows checking if sort.py correctly sorts the relevant lines in a profile without having to overwrite it, which makes debugging and testing easier (for example, in #6261). Note: If it finds items that are not sorted, it still sorts them, prints the diff and returns an error. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 10:47:38 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5934
No description provided.