[PR #6261] [MERGED] build: sort.py: filter empty and duplicate items #5915

New issue

Closed

opened 2026-05-05 10:47:16 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:47:16 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/6261
Author: @kmk3
Created: 3/3/2024
Status: ✅ Merged
Merged: 3/8/2024
Merged by: @kmk3

Base: master ← Head: sort-py-strip-commas

📝 Commits (1)

908e5a1 build: sort.py: filter empty and duplicate items

📊 Changes

2 files changed (+3 additions, -2 deletions)

View changed files

📝 contrib/sort.py (+2 -1)
📝 etc/profile-a-l/dnscrypt-proxy.profile (+1 -1)

📄 Description

Note: This seems to already be done for protocol lines.

Before:

$ ./contrib/sort.py test.profile
sort.py: checking 1 profile(s)...
test.profile:1:-private-etc ,,bar,,foo,,bar,,,
test.profile:1:+private-etc ,,,,,,,bar,bar,foo
test.profile:2:-protocol ,,unix,,bluetooth,,unix,,inet,,,
test.profile:2:+protocol unix,inet,bluetooth
[ Fixed ] test.profile

After:

$ ./contrib/sort.py test.profile
sort.py: checking 1 profile(s)...
test.profile:1:-private-etc ,,bar,,foo,,bar,,,
test.profile:1:+private-etc bar,foo
test.profile:2:-protocol ,,unix,,bluetooth,,unix,,inet,,,
test.profile:2:+protocol unix,inet,bluetooth
[ Fixed ] test.profile

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/6261 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 3/3/2024 **Status:** ✅ Merged **Merged:** 3/8/2024 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `sort-py-strip-commas` --- ### 📝 Commits (1) - [`908e5a1`](https://github.com/netblue30/firejail/commit/908e5a1a437bb7907f78fac8cfecdfa92e26bad0) build: sort.py: filter empty and duplicate items ### 📊 Changes **2 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `contrib/sort.py` (+2 -1) 📝 `etc/profile-a-l/dnscrypt-proxy.profile` (+1 -1) </details> ### 📄 Description Note: This seems to already be done for `protocol` lines. Before: $ ./contrib/sort.py test.profile sort.py: checking 1 profile(s)... test.profile:1:-private-etc ,,bar,,foo,,bar,,, test.profile:1:+private-etc ,,,,,,,bar,bar,foo test.profile:2:-protocol ,,unix,,bluetooth,,unix,,inet,,, test.profile:2:+protocol unix,inet,bluetooth [ Fixed ] test.profile After: $ ./contrib/sort.py test.profile sort.py: checking 1 profile(s)... test.profile:1:-private-etc ,,bar,,foo,,bar,,, test.profile:1:+private-etc bar,foo test.profile:2:-protocol ,,unix,,bluetooth,,unix,,inet,,, test.profile:2:+protocol unix,inet,bluetooth [ Fixed ] test.profile --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:47:16 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5915

No description provided.

Rows
Columns