[PR #6230] [MERGED] build: reduce hardcoding and inconsistencies #5886

New issue

Closed

opened 2026-05-05 10:46:43 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:46:43 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/6230
Author: @kmk3
Created: 2/29/2024
Status: ✅ Merged
Merged: 2/29/2024
Merged by: @netblue30

Base: master ← Head: build-reduce-inconsistencies

📝 Commits (10+)

48db047 build: use generic wildcard on package install
c9531d9 build: add print-version target and use in CI
ae00d7e ci: add and use PKGNAME variable in in debian_ci
95f866e ci: remove unnecessary dependencies and endpoints
f7e7477 ci: run check-c.yml on any C code change
99fb723 ci: move build_no_apparmor job near other similar jobs
2f69200 ci: update top-level comment in .gitlab-ci.yml
223f71d build: format gcov.sh
93a5d7a build: standardize parallel make arguments
2301ab2 build: standardize ./configure arguments

📊 Changes

12 files changed (+215 additions, -126 deletions)

View changed files

📝 .github/workflows/build-extra.yml (+4 -5)
📝 .github/workflows/build.yml (+6 -6)
📝 .github/workflows/check-c.yml (+6 -5)
📝 .github/workflows/test.yml (+25 -20)
📝 .gitlab-ci.yml (+59 -45)
📝 Makefile (+4 -0)
📝 contrib/update_deb.sh (+1 -1)
📝 gcov.sh (+12 -4)
📝 mkdeb.sh (+1 -1)
📝 platform/rpm/mkrpm.sh (+2 -0)
📝 src/tools/mkcoverit.sh (+1 -1)
📝 test/compile/compile.sh (+94 -38)

📄 Description

Main changes:

build: reduce TARNAME hardcoding
build: standardize parallel make arguments
build: standardize ./configure arguments

Relates to #5148 #5960 #6224.

This is a follow-up to #6222.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/6230 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 2/29/2024 **Status:** ✅ Merged **Merged:** 2/29/2024 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `build-reduce-inconsistencies` --- ### 📝 Commits (10+) - [`48db047`](https://github.com/netblue30/firejail/commit/48db047cdbf4836ed7e6e0f2556883f6c7b891e6) build: use generic wildcard on package install - [`c9531d9`](https://github.com/netblue30/firejail/commit/c9531d95ed3f12c382a0292e9eb508a9b9c96532) build: add print-version target and use in CI - [`ae00d7e`](https://github.com/netblue30/firejail/commit/ae00d7e282ae36d8ba09b230ef46292444e0cef8) ci: add and use PKGNAME variable in in debian_ci - [`95f866e`](https://github.com/netblue30/firejail/commit/95f866e3c6a29d77825317c6f7e93289cc3f651d) ci: remove unnecessary dependencies and endpoints - [`f7e7477`](https://github.com/netblue30/firejail/commit/f7e74772cfe89b5a72c2f47ecfa2cbea18599842) ci: run check-c.yml on any C code change - [`99fb723`](https://github.com/netblue30/firejail/commit/99fb723317c1a9eb65c013f48b41785f125d8170) ci: move build_no_apparmor job near other similar jobs - [`2f69200`](https://github.com/netblue30/firejail/commit/2f6920044ef851bcdaabe744098e9ec8db07798d) ci: update top-level comment in .gitlab-ci.yml - [`223f71d`](https://github.com/netblue30/firejail/commit/223f71df7d7f39dd5333d28230866064af5234da) build: format gcov.sh - [`93a5d7a`](https://github.com/netblue30/firejail/commit/93a5d7a2f5f8771f79ae89936a74ca45bfe48660) build: standardize parallel make arguments - [`2301ab2`](https://github.com/netblue30/firejail/commit/2301ab23488b9db95eba40750f355a4439468b89) build: standardize ./configure arguments ### 📊 Changes **12 files changed** (+215 additions, -126 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build-extra.yml` (+4 -5) 📝 `.github/workflows/build.yml` (+6 -6) 📝 `.github/workflows/check-c.yml` (+6 -5) 📝 `.github/workflows/test.yml` (+25 -20) 📝 `.gitlab-ci.yml` (+59 -45) 📝 `Makefile` (+4 -0) 📝 `contrib/update_deb.sh` (+1 -1) 📝 `gcov.sh` (+12 -4) 📝 `mkdeb.sh` (+1 -1) 📝 `platform/rpm/mkrpm.sh` (+2 -0) 📝 `src/tools/mkcoverit.sh` (+1 -1) 📝 `test/compile/compile.sh` (+94 -38) </details> ### 📄 Description Main changes: * build: reduce TARNAME hardcoding * build: standardize parallel make arguments * build: standardize ./configure arguments Relates to #5148 #5960 #6224. This is a follow-up to #6222. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:46:43 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5886

No description provided.

Rows
Columns