[PR #6222] [MERGED] build: allow overriding certain tools & sync targets with CI #5881

New issue

Closed

opened 2026-05-05 10:46:38 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:46:38 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/6222
Author: @kmk3
Created: 2/24/2024
Status: ✅ Merged
Merged: 2/28/2024
Merged by: @kmk3

Base: master ← Head: build-override-tools

📝 Commits (3)

93d623f build: allow overriding certain tools
f4f7a81 build: sync cppcheck targets with CI
1f6400b build: sync scan-build target with CI

📊 Changes

8 files changed (+236 additions, -61 deletions)

View changed files

📝 .github/workflows/check-c.yml (+14 -8)
📝 Makefile (+16 -3)
📝 config.mk.in (+5 -0)
📝 configure (+193 -45)
📝 configure.ac (+5 -2)
📝 src/bash_completion/Makefile (+1 -1)
📝 src/man/Makefile (+1 -1)
📝 src/zsh_completion/Makefile (+1 -1)

📄 Description

Allow overriding the following tools at configure-time and build-time:

codespell
cppcheck
gawk
scan-build

For example, instead of hardcoding gawk, enable overriding it at
configure-time with:

./configure GAWK=/path/to/gawk

To override it for a single make invocation:

make GAWK=/path/to/gawk

Also, add default values for the programs that are not found (rather
than leaving the variables empty), to make error messages clearer when
trying to run them:

$ make CPPCHECK= cppcheck-old
[...]
force --error-exitcode=1 --enable=warning,performance .
make: force: No such file or directory
$ make CPPCHECK=cppcheck cppcheck-old
[...]
cppcheck --force --error-exitcode=1 --enable=warning,performance .
make: cppcheck: No such file or directory

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/6222 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 2/24/2024 **Status:** ✅ Merged **Merged:** 2/28/2024 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `build-override-tools` --- ### 📝 Commits (3) - [`93d623f`](https://github.com/netblue30/firejail/commit/93d623fdf9bee70bfae50168ac163825361f38e0) build: allow overriding certain tools - [`f4f7a81`](https://github.com/netblue30/firejail/commit/f4f7a814e77dc338db655987f6eb1beb6e3ae7ea) build: sync cppcheck targets with CI - [`1f6400b`](https://github.com/netblue30/firejail/commit/1f6400bd89913d804b9803394c9c1bb629a7e97f) build: sync scan-build target with CI ### 📊 Changes **8 files changed** (+236 additions, -61 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/check-c.yml` (+14 -8) 📝 `Makefile` (+16 -3) 📝 `config.mk.in` (+5 -0) 📝 `configure` (+193 -45) 📝 `configure.ac` (+5 -2) 📝 `src/bash_completion/Makefile` (+1 -1) 📝 `src/man/Makefile` (+1 -1) 📝 `src/zsh_completion/Makefile` (+1 -1) </details> ### 📄 Description Allow overriding the following tools at configure-time and build-time: * codespell * cppcheck * gawk * scan-build For example, instead of hardcoding `gawk`, enable overriding it at configure-time with: ./configure GAWK=/path/to/gawk To override it for a single `make` invocation: make GAWK=/path/to/gawk Also, add default values for the programs that are not found (rather than leaving the variables empty), to make error messages clearer when trying to run them: $ make CPPCHECK= cppcheck-old [...] force --error-exitcode=1 --enable=warning,performance . make: force: No such file or directory $ make CPPCHECK=cppcheck cppcheck-old [...] cppcheck --force --error-exitcode=1 --enable=warning,performance . make: cppcheck: No such file or directory --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:46:38 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:47:44 -06:00

[PR #6298] [MERGED] profiles: add allow-nodejs.inc to profile.template #5937

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5881

No description provided.

Rows
Columns