[PR #6159] [MERGED] build: use CPPFLAGS instead of INCLUDE in compile targets #5852

New issue

Closed

opened 2026-05-05 10:46:08 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:46:08 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/6159
Author: @kmk3
Created: 1/17/2024
Status: ✅ Merged
Merged: 1/20/2024
Merged by: @kmk3

Base: master ← Head: build-use-cppflags

📝 Commits (1)

5b1ce32 build: use CPPFLAGS instead of INCLUDE in compile targets

📊 Changes

5 files changed (+5 additions, -2 deletions)

View changed files

📝 config.mk.in (+1 -0)
📝 configure (+1 -0)
📝 configure.ac (+1 -0)
📝 src/prog.mk (+1 -1)
📝 src/so.mk (+1 -1)

📄 Description

With this, CFLAGS and CPPFLAGS are used when compiling and LDFLAGS when
linking, just like in the built-in GNU make rules. From make -p:

COMPILE.c = $(CC) $(CFLAGS) $(CPPFLAGS) $(TARGET_ARCH) -c
LINK.c = $(CC) $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) $(TARGET_ARCH)
LINK.o = $(CC) $(LDFLAGS) $(TARGET_ARCH)

Note: It is unclear where the INCLUDE variable comes from; it is not
documented in autoconf nor GNU make and automake (which itself is not
used in this repository) only mentions INCLUDES:

`INCLUDES`
     This does the same job as `AM_CPPFLAGS` (or any per-target
     `_CPPFLAGS` variable if it is used).  It is an older name for
     the same functionality.  This variable is deprecated; we
     suggest using `AM_CPPFLAGS` and per-target `_CPPFLAGS` instead.

Environment: automake 1.16.5-2 and GNU make 4.4.1 on Artix Linux.

See also commit 671c3f249 ("build: actually set LDFLAGS and LIBS in
makefiles", 2022-11-30) / PR #5504.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/6159 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 1/17/2024 **Status:** ✅ Merged **Merged:** 1/20/2024 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `build-use-cppflags` --- ### 📝 Commits (1) - [`5b1ce32`](https://github.com/netblue30/firejail/commit/5b1ce32bbced20b01be2dcea4ecca510a7194b75) build: use CPPFLAGS instead of INCLUDE in compile targets ### 📊 Changes **5 files changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `config.mk.in` (+1 -0) 📝 `configure` (+1 -0) 📝 `configure.ac` (+1 -0) 📝 `src/prog.mk` (+1 -1) 📝 `src/so.mk` (+1 -1) </details> ### 📄 Description With this, CFLAGS and CPPFLAGS are used when compiling and LDFLAGS when linking, just like in the built-in GNU make rules. From `make -p`: COMPILE.c = $(CC) $(CFLAGS) $(CPPFLAGS) $(TARGET_ARCH) -c LINK.c = $(CC) $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) $(TARGET_ARCH) LINK.o = $(CC) $(LDFLAGS) $(TARGET_ARCH) Note: It is unclear where the `INCLUDE` variable comes from; it is not documented in autoconf nor GNU make and automake (which itself is not used in this repository) only mentions `INCLUDES`: `INCLUDES` This does the same job as `AM_CPPFLAGS` (or any per-target `_CPPFLAGS` variable if it is used). It is an older name for the same functionality. This variable is deprecated; we suggest using `AM_CPPFLAGS` and per-target `_CPPFLAGS` instead. Environment: automake 1.16.5-2 and GNU make 4.4.1 on Artix Linux. See also commit 671c3f249 ("build: actually set LDFLAGS and LIBS in makefiles", 2022-11-30) / PR #5504. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:46:08 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5852

No description provided.

Rows
Columns