[PR #6157] Fix duplicate address detection (ARP) #5849

Open
opened 2026-05-05 10:46:04 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/6157
Author: @brianvanderburg2
Created: 1/16/2024
Status: 🔄 Open

Base: masterHead: master


📝 Commits (1)

  • 35a8a53 Fix duplicate address detection

📊 Changes

1 file changed (+18 additions, -7 deletions)

View changed files

📝 src/firejail/arp.c (+18 -7)

📄 Description

The original code compare the target IP of an ARP reply packet with the srcaddr/sender IP of the request packet. Instead it should compare the source IP of the ARP reply with the destaddr/target IP of the request packet. In addition this adds the check for ARP requests with the same IP address in case other systems are probing for the same IP at the same time as per recommendation in RFC5227:

image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/6157 **Author:** [@brianvanderburg2](https://github.com/brianvanderburg2) **Created:** 1/16/2024 **Status:** 🔄 Open **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`35a8a53`](https://github.com/netblue30/firejail/commit/35a8a53612a84bc73bf11bf6d860eb039d512255) Fix duplicate address detection ### 📊 Changes **1 file changed** (+18 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/arp.c` (+18 -7) </details> ### 📄 Description The original code compare the target IP of an ARP reply packet with the srcaddr/sender IP of the request packet. Instead it should compare the source IP of the ARP reply with the destaddr/target IP of the request packet. In addition this adds the check for ARP requests with the same IP address in case other systems are probing for the same IP at the same time as per recommendation in RFC5227: ![image](https://github.com/netblue30/firejail/assets/2142408/4a6d8a0b-afad-45fe-9c93-4bb975d193da) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror added the
pull-request
label 2026-05-05 10:46:04 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5849
No description provided.