[PR #6129] [MERGED] Revert "lookup xauth in PATH" #5838

New issue

Closed

opened 2026-05-05 10:45:53 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:45:53 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/6129
Author: @kmk3
Created: 12/14/2023
Status: ✅ Merged
Merged: 12/21/2023
Merged by: @netblue30

Base: master ← Head: revert-lookup-xauth

📝 Commits (1)

8f33e72 Revert "Lookup xauth in PATH."

📊 Changes

2 files changed (+13 additions, -23 deletions)

View changed files

📝 src/firejail/fs_lib2.c (+1 -5)
📝 src/firejail/x11.c (+12 -18)

📄 Description

This reverts commit 407c05ebef.

If --private-lib is used (and firejail is configured with
--enable-private-lib), the following error occurs:

$ firejail --quiet --noprofile --private-lib true
firejail: fs_lib.c:56: find_in_path: Assertion `geteuid() != 0' failed.
Error: proc 10000 cannot sync with peer: unexpected EOF
Peer 10001 unexpectedly killed (Segmentation fault)

Given that it causes an uid assertion failure, the logic appears to not
be correct and the current behavior may be unsafe, so for now revert
that commit until the issue is properly addressed.

Relates to #6006 #6087.

Fixes #6113.

Cc: @chestnykh @hashelq

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/6129 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 12/14/2023 **Status:** ✅ Merged **Merged:** 12/21/2023 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `revert-lookup-xauth` --- ### 📝 Commits (1) - [`8f33e72`](https://github.com/netblue30/firejail/commit/8f33e7284cb5dc78e6543cfad6f9a1c51556f564) Revert "Lookup xauth in PATH." ### 📊 Changes **2 files changed** (+13 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/fs_lib2.c` (+1 -5) 📝 `src/firejail/x11.c` (+12 -18) </details> ### 📄 Description This reverts commit 407c05ebefe23e725f858b6170b3e52659e044a2. If --private-lib is used (and firejail is configured with --enable-private-lib), the following error occurs: $ firejail --quiet --noprofile --private-lib true firejail: fs_lib.c:56: find_in_path: Assertion `geteuid() != 0' failed. Error: proc 10000 cannot sync with peer: unexpected EOF Peer 10001 unexpectedly killed (Segmentation fault) Given that it causes an uid assertion failure, the logic appears to not be correct and the current behavior may be unsafe, so for now revert that commit until the issue is properly addressed. Relates to #6006 #6087. Fixes #6113. Cc: @chestnykh @hashelq --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:45:53 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5838

No description provided.

Rows
Columns