[PR #6104] [MERGED] ci: re-enable sort.py #5827

New issue

Closed

opened 2026-05-05 10:45:40 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:45:40 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/6104
Author: @kmk3
Created: 11/25/2023
Status: ✅ Merged
Merged: 12/4/2023
Merged by: @netblue30

Base: master ← Head: ci-enable-sort-py

📝 Commits (1)

78bbcb7 ci: re-enable sort.py

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 .github/workflows/check-profiles.yml (+4 -4)

📄 Description

It was disabled on commit df6ea884f ("merges, disable sort.py in profile
checks temporarely, two more private-etc profiles", 2023-02-14).

Currently all profiles are sorted and there are no ongoing private-etc
changes, so it should be safe to re-enable.

Note that the script is useful to catch sorting issues not only in
private-etc but also in other commands, such as seccomp[1] [2].

This is a follow-up to #6070.

Relates to #5610.

[1] https://github.com/netblue30/firejail/pull/6066#discussion_r1372055800
[2] https://github.com/netblue30/firejail/pull/6067#discussion_r1372027243

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/6104 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 11/25/2023 **Status:** ✅ Merged **Merged:** 12/4/2023 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `ci-enable-sort-py` --- ### 📝 Commits (1) - [`78bbcb7`](https://github.com/netblue30/firejail/commit/78bbcb7462e776fbf5ccc2a12484e663f777e172) ci: re-enable sort.py ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/check-profiles.yml` (+4 -4) </details> ### 📄 Description It was disabled on commit df6ea884f ("merges, disable sort.py in profile checks temporarely, two more private-etc profiles", 2023-02-14). Currently all profiles are sorted and there are no ongoing `private-etc` changes, so it should be safe to re-enable. Note that the script is useful to catch sorting issues not only in `private-etc` but also in other commands, such as `seccomp`[1] [2]. This is a follow-up to #6070. Relates to #5610. [1] https://github.com/netblue30/firejail/pull/6066#discussion_r1372055800 [2] https://github.com/netblue30/firejail/pull/6067#discussion_r1372027243 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:45:40 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5827

No description provided.

Rows
Columns