[PR #5956] [MERGED] build: add missing makefile dep & syntax improvements #5752

Closed
opened 2026-05-05 10:44:17 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5956
Author: @kmk3
Created: 8/13/2023
Status: Merged
Merged: 8/14/2023
Merged by: @kmk3

Base: masterHead: build-fix-dep-syntax


📝 Commits (3)

  • 8e79f18 build: add missing makefile dep
  • c619f13 build: print syntax list generation
  • 204c45a build: improve char escaping of syntax lists

📊 Changes

2 files changed (+37 additions, -30 deletions)

View changed files

📝 Makefile (+36 -29)
📝 contrib/syntax/lists/profile_commands_arg0.list (+1 -1)

📄 Description

Make the non-phony targets that are defined in the root Makefile depend
on it, to ensure that they get re-generated if their recipes change.

Note that these targets are generated nearly instantly, so this should
not noticeably affect rebuild times.

Relates to #5627.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5956 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 8/13/2023 **Status:** ✅ Merged **Merged:** 8/14/2023 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `build-fix-dep-syntax` --- ### 📝 Commits (3) - [`8e79f18`](https://github.com/netblue30/firejail/commit/8e79f18cf9459ea194d5b50aef7e7b1ee40e8e07) build: add missing makefile dep - [`c619f13`](https://github.com/netblue30/firejail/commit/c619f13ea0335d5f4debc6fb16900043e87fb04a) build: print syntax list generation - [`204c45a`](https://github.com/netblue30/firejail/commit/204c45adee77e9cebfdb9458f68d31f11cbdc679) build: improve char escaping of syntax lists ### 📊 Changes **2 files changed** (+37 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+36 -29) 📝 `contrib/syntax/lists/profile_commands_arg0.list` (+1 -1) </details> ### 📄 Description Make the non-phony targets that are defined in the root Makefile depend on it, to ensure that they get re-generated if their recipes change. Note that these targets are generated nearly instantly, so this should not noticeably affect rebuild times. Relates to #5627. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 10:44:17 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5752
No description provided.