[PR #5950] [CLOSED] profiles: safeguard single line comments #5748

New issue

Closed

opened 2026-05-05 10:44:12 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:44:12 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5950
Author: @ghost
Created: 8/11/2023
Status: ❌ Closed

Base: master ← Head: comm-improv

📝 Commits (10+)

eaa29cc akonadi_control: safeguard single line comments
8e244f7 artha: safeguard single line comments
c74f8c3 atril: safeguard single line comments
12eec45 audio-recorder: safeguard single line comments
7b193f4 authenticator: safeguard single line comments
45caf53 autokey-common: safeguard single line comments
f1c2992 bcompare: safeguard single line comments
23b31f0 cameramonitor: safeguard single line comments
918fe78 chromium-common: safeguard single line comments
cd4f101 clac: safeguard single line comments

📊 Changes

85 files changed (+142 additions, -150 deletions)

View changed files

📝 etc/inc/disable-common.inc (+6 -6)
📝 etc/inc/disable-devel.inc (+2 -4)
📝 etc/profile-a-l/akonadi_control.profile (+1 -1)
📝 etc/profile-a-l/artha.profile (+1 -1)
📝 etc/profile-a-l/atril.profile (+1 -1)
📝 etc/profile-a-l/audio-recorder.profile (+1 -1)
📝 etc/profile-a-l/authenticator.profile (+1 -1)
📝 etc/profile-a-l/autokey-common.profile (+1 -1)
📝 etc/profile-a-l/bcompare.profile (+1 -1)
📝 etc/profile-a-l/cameramonitor.profile (+1 -1)
📝 etc/profile-a-l/chromium-common.profile (+2 -2)
📝 etc/profile-a-l/clac.profile (+2 -2)
📝 etc/profile-a-l/clawsker.profile (+1 -1)
📝 etc/profile-a-l/clipgrab.profile (+1 -1)
📝 etc/profile-a-l/d-feet.profile (+2 -2)
📝 etc/profile-a-l/dconf-editor.profile (+1 -1)
📝 etc/profile-a-l/ddgtk.profile (+1 -1)
📝 etc/profile-a-l/devhelp.profile (+2 -2)
📝 etc/profile-a-l/dig.profile (+1 -1)
📝 etc/profile-a-l/digikam.profile (+1 -1)

...and 65 more files

📄 Description

Using - on single line comments can break easily when users just uncomment a line. It's advised to use # instead.

Relates to https://github.com/netblue30/firejail/pull/5942

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5950 **Author:** [@ghost](https://github.com/ghost) **Created:** 8/11/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `comm-improv` --- ### 📝 Commits (10+) - [`eaa29cc`](https://github.com/netblue30/firejail/commit/eaa29ccc336c033d13d195b186b91a6a5fc63ef3) akonadi_control: safeguard single line comments - [`8e244f7`](https://github.com/netblue30/firejail/commit/8e244f72c30a45f92a898e87c18d0f76aae3453c) artha: safeguard single line comments - [`c74f8c3`](https://github.com/netblue30/firejail/commit/c74f8c3dc89d581f98102ebb186be8f4bf123ada) atril: safeguard single line comments - [`12eec45`](https://github.com/netblue30/firejail/commit/12eec45abbabdccccecc900005b2254c83e9a3c6) audio-recorder: safeguard single line comments - [`7b193f4`](https://github.com/netblue30/firejail/commit/7b193f4d4f4d913002030b225c347cd426301035) authenticator: safeguard single line comments - [`45caf53`](https://github.com/netblue30/firejail/commit/45caf5348ec46284100edf5da6d7141b189ed324) autokey-common: safeguard single line comments - [`f1c2992`](https://github.com/netblue30/firejail/commit/f1c299218a2ca805c77a719bbabd9b665c133487) bcompare: safeguard single line comments - [`23b31f0`](https://github.com/netblue30/firejail/commit/23b31f03023eefc255cb99308c16c1b369789677) cameramonitor: safeguard single line comments - [`918fe78`](https://github.com/netblue30/firejail/commit/918fe78b7b98a3e5ffd7363c151b38d1d8770f62) chromium-common: safeguard single line comments - [`cd4f101`](https://github.com/netblue30/firejail/commit/cd4f10146622ee74316245f8c8723d00090d3665) clac: safeguard single line comments ### 📊 Changes **85 files changed** (+142 additions, -150 deletions) <details> <summary>View changed files</summary> 📝 `etc/inc/disable-common.inc` (+6 -6) 📝 `etc/inc/disable-devel.inc` (+2 -4) 📝 `etc/profile-a-l/akonadi_control.profile` (+1 -1) 📝 `etc/profile-a-l/artha.profile` (+1 -1) 📝 `etc/profile-a-l/atril.profile` (+1 -1) 📝 `etc/profile-a-l/audio-recorder.profile` (+1 -1) 📝 `etc/profile-a-l/authenticator.profile` (+1 -1) 📝 `etc/profile-a-l/autokey-common.profile` (+1 -1) 📝 `etc/profile-a-l/bcompare.profile` (+1 -1) 📝 `etc/profile-a-l/cameramonitor.profile` (+1 -1) 📝 `etc/profile-a-l/chromium-common.profile` (+2 -2) 📝 `etc/profile-a-l/clac.profile` (+2 -2) 📝 `etc/profile-a-l/clawsker.profile` (+1 -1) 📝 `etc/profile-a-l/clipgrab.profile` (+1 -1) 📝 `etc/profile-a-l/d-feet.profile` (+2 -2) 📝 `etc/profile-a-l/dconf-editor.profile` (+1 -1) 📝 `etc/profile-a-l/ddgtk.profile` (+1 -1) 📝 `etc/profile-a-l/devhelp.profile` (+2 -2) 📝 `etc/profile-a-l/dig.profile` (+1 -1) 📝 `etc/profile-a-l/digikam.profile` (+1 -1) _...and 65 more files_ </details> ### 📄 Description Using `-` on single line comments can break easily when users just uncomment a line. It's advised to use `#` instead. Relates to https://github.com/netblue30/firejail/pull/5942 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:44:12 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5748

No description provided.

Rows
Columns