[PR #5927] [MERGED] build: fix some shellcheck issues & use config.sh in more scripts #5734

New issue

Closed

opened 2026-05-05 10:43:55 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:43:55 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5927
Author: @kmk3
Created: 7/28/2023
Status: ✅ Merged
Merged: 7/30/2023
Merged by: @kmk3

Base: master ← Head: build-use-config-sh

📝 Commits (2)

59ed39e build: fix shellcheck issues in mkrpm.sh/compile.sh
200f389 build: use config.sh in more scripts

📊 Changes

4 files changed (+46 additions, -41 deletions)

View changed files

📝 Makefile (+4 -4)
📝 mkasc.sh (+1 -1)
📝 platform/rpm/mkrpm.sh (+19 -15)
📝 test/compile/compile.sh (+22 -21)

📄 Description

This removes the need to manually pass variables such as $(TARNAME)
and $(VERSION) to shell scripts in the root Makefile.

Relates to #5140.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5927 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 7/28/2023 **Status:** ✅ Merged **Merged:** 7/30/2023 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `build-use-config-sh` --- ### 📝 Commits (2) - [`59ed39e`](https://github.com/netblue30/firejail/commit/59ed39ec460743e97bcce22e62d27ba0a569b82f) build: fix shellcheck issues in mkrpm.sh/compile.sh - [`200f389`](https://github.com/netblue30/firejail/commit/200f389ed0f56ba42160fe135e3701757a8df94c) build: use config.sh in more scripts ### 📊 Changes **4 files changed** (+46 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+4 -4) 📝 `mkasc.sh` (+1 -1) 📝 `platform/rpm/mkrpm.sh` (+19 -15) 📝 `test/compile/compile.sh` (+22 -21) </details> ### 📄 Description This removes the need to manually pass variables such as `$(TARNAME)` and `$(VERSION)` to shell scripts in the root Makefile. Relates to #5140. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:43:55 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5734

No description provided.

Rows
Columns