mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[PR #5905] [MERGED] profiles: fix misc in kmail/transmission-qt & add kontact.profile #5718
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#5718
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/netblue30/firejail/pull/5905
Author: @Sadoon-AlBader
Created: 7/17/2023
Status: ✅ Merged
Merged: 12/18/2024
Merged by: @netblue30
Base:
master← Head:master📝 Commits (10+)
d578e92remove nosound from kmail.profilef49c3ebEnable notifications to kmail.profile1e92326Create kontact.profile7b5d946Add systray option as a commented config to transmission-qt1f40d91Fix kmail.profile ordering based on templatef6b3857Fix kontact.profile ordering based on template0e9c8eaPrompt the user to add lines to .local to enable notifications4d00897Enable systray support with condition ?ALLOW_TRAY5057ab1Add kontact to firecfg2c80515make kontact.profile a redirect of kmail.profile📊 Changes
4 files changed (+30 additions, -2 deletions)
View changed files
📝
etc/profile-a-l/kmail.profile(+6 -2)➕
etc/profile-a-l/kontact.profile(+20 -0)📝
etc/profile-m-z/transmission-qt.profile(+3 -0)📝
src/firecfg/firecfg.config(+1 -0)📄 Description
This removes "nosound" from kmail.profile to allow notification sounds, and also adds a "dbus-user.talk org.freedesktop.Notifications" to allow notifications to start.
Also adds kontact.profile based on kmail.profile, have been using it and works well.
Also edits transmission-qt.profile to allow systray, commented out as is usually the case with profiles, but better to at least let the user know that it might be necessary to add to .local if they need systray.
EDIT: if the maintainers also prefer to keep "nosound" for kmail, it might make sense to also add it to kontact.profile since I didn't add it there to start, I think it makes sense to either remove it or add a comment letting the user know that sound notifications won't work unless they "ignore nosound"
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.