[PR #5894] [MERGED] modif: drop deprecated 'shell' option references #5714

New issue

Closed

opened 2026-05-05 10:43:32 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:43:32 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5894
Author: @ghost
Created: 7/10/2023
Status: ✅ Merged
Merged: 7/19/2023
Merged by: @undefined

Base: master ← Head: shell-none-cleaning

📝 Commits (1)

d8ab6d9 modif: drop deprecated 'shell' option references

📊 Changes

21 files changed (+11 additions, -37 deletions)

View changed files

📝 etc/profile-a-l/beaker.profile (+0 -1)
📝 etc/profile-a-l/default.profile (+0 -1)
📝 etc/profile-a-l/fdns.profile (+0 -1)
📝 etc/profile-a-l/gnome-nettool.profile (+0 -1)
📝 etc/profile-a-l/jitsi-meet-desktop.profile (+0 -1)
📝 etc/profile-m-z/pidgin.profile (+0 -1)
📝 etc/profile-m-z/rocketchat.profile (+0 -1)
📝 etc/profile-m-z/server.profile (+0 -1)
📝 etc/templates/profile.template (+1 -2)
📝 src/bash_completion/firejail.bash_completion.in (+0 -4)
📝 src/fbuilder/build_profile.c (+0 -1)
📝 src/firejail/main.c (+1 -1)
📝 src/firejail/profile.c (+2 -2)
📝 src/man/firejail-profile.5.in (+0 -5)
📝 src/zsh_completion/_firejail.in (+0 -2)
➖ test/environment/shell-none.profile (+0 -1)
📝 test/profiles/ignore.exp (+3 -3)
📝 test/profiles/ignore.profile (+1 -1)
📝 test/profiles/ignore2.profile (+2 -2)
📝 test/profiles/ignore3.profile (+1 -1)

...and 1 more files

📄 Description

The shell option has been removed. Remove stale references.

This does NOT remove shell none-related code comments in:

Relates to #5196.

Suggested by #5891.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5894 **Author:** [@ghost](https://github.com/ghost) **Created:** 7/10/2023 **Status:** ✅ Merged **Merged:** 7/19/2023 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `shell-none-cleaning` --- ### 📝 Commits (1) - [`d8ab6d9`](https://github.com/netblue30/firejail/commit/d8ab6d9ee8f90215aee3913be2f9fe8358f66f72) modif: drop deprecated 'shell' option references ### 📊 Changes **21 files changed** (+11 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `etc/profile-a-l/beaker.profile` (+0 -1) 📝 `etc/profile-a-l/default.profile` (+0 -1) 📝 `etc/profile-a-l/fdns.profile` (+0 -1) 📝 `etc/profile-a-l/gnome-nettool.profile` (+0 -1) 📝 `etc/profile-a-l/jitsi-meet-desktop.profile` (+0 -1) 📝 `etc/profile-m-z/pidgin.profile` (+0 -1) 📝 `etc/profile-m-z/rocketchat.profile` (+0 -1) 📝 `etc/profile-m-z/server.profile` (+0 -1) 📝 `etc/templates/profile.template` (+1 -2) 📝 `src/bash_completion/firejail.bash_completion.in` (+0 -4) 📝 `src/fbuilder/build_profile.c` (+0 -1) 📝 `src/firejail/main.c` (+1 -1) 📝 `src/firejail/profile.c` (+2 -2) 📝 `src/man/firejail-profile.5.in` (+0 -5) 📝 `src/zsh_completion/_firejail.in` (+0 -2) ➖ `test/environment/shell-none.profile` (+0 -1) 📝 `test/profiles/ignore.exp` (+3 -3) 📝 `test/profiles/ignore.profile` (+1 -1) 📝 `test/profiles/ignore2.profile` (+2 -2) 📝 `test/profiles/ignore3.profile` (+1 -1) _...and 1 more files_ </details> ### 📄 Description The `shell` option has been removed. Remove stale references. This does NOT remove `shell none`-related code comments in: - [src/firejail/fs_lib.c](https://github.com/netblue30/firejail/blob/1d5fff9034796d69f287abbcfedff0342990fb7c/src/firejail/fs_lib.c#L433-L441) - [src/firejail/join.c](https://github.com/netblue30/firejail/blob/1d5fff9034796d69f287abbcfedff0342990fb7c/src/firejail/join.c#L415-L417) Relates to #5196. Suggested by #5891. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:43:32 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5714

No description provided.

Rows
Columns