[PR #5866] [MERGED] build: organize and standardize make vars and targets #5700

New issue

Closed

opened 2026-05-05 10:43:16 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:43:16 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5866
Author: @kmk3
Created: 6/25/2023
Status: ✅ Merged
Merged: 6/27/2023
Merged by: @kmk3

Base: master ← Head: build-organize-make-vars

📝 Commits (10+)

862dff0 build: remove MOD_SRCS variable
5cba21b build: rename MOD vars to EXTRA vars
b9864fd build: rename TOCLEAN and TODISTCLEAN variables
75587a4 build: standardize clean/distclean targets in src
7ff2d6b build: line-wrap MANFLAGS
07b9414 build: sort MANFLAGS and nearby variables
5801ce0 build: split misc flags from MANFLAGS
cddf20f build: remove redundant LDFLAGS in so.mk
9c08da1 build: move common CFLAGS/LDFLAGS first
0771612 build: move remaining build flags into config.mk.in

📊 Changes

21 files changed (+104 additions, -84 deletions)

View changed files

📝 config.mk.in (+62 -19)
📝 src/etc-cleanup/Makefile (+1 -1)
📝 src/fbuilder/Makefile (+1 -1)
📝 src/fcopy/Makefile (+2 -2)
📝 src/fids/Makefile (+1 -1)
📝 src/firecfg/Makefile (+2 -2)
📝 src/firejail/Makefile (+2 -2)
📝 src/firemon/Makefile (+2 -2)
📝 src/fldd/Makefile (+2 -2)
📝 src/fnet/Makefile (+2 -2)
📝 src/fnetfilter/Makefile (+2 -2)
📝 src/fsec-optimize/Makefile (+2 -2)
📝 src/fsec-print/Makefile (+2 -2)
📝 src/fseccomp/Makefile (+2 -2)
📝 src/fzenity/Makefile (+1 -1)
📝 src/jailcheck/Makefile (+2 -2)
📝 src/libpostexecseccomp/Makefile (+1 -1)
📝 src/libtracelog/Makefile (+1 -1)
📝 src/profstats/Makefile (+1 -1)
📝 src/prog.mk (+6 -20)

...and 1 more files

📄 Description

Main changes:

build: rename MOD vars to EXTRA vars
build: rename TOCLEAN and TODISTCLEAN variables
build: standardize clean/distclean targets in src
build: remove redundant LDFLAGS in so.mk
build: move remaining build flags into config.mk.in
build: standardize common CFLAGS

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5866 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 6/25/2023 **Status:** ✅ Merged **Merged:** 6/27/2023 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `build-organize-make-vars` --- ### 📝 Commits (10+) - [`862dff0`](https://github.com/netblue30/firejail/commit/862dff04436649b533deaf489f5715e273a5bef7) build: remove MOD_SRCS variable - [`5cba21b`](https://github.com/netblue30/firejail/commit/5cba21bad5383a4d2c4f7da5df7395e0c3b9eba3) build: rename MOD vars to EXTRA vars - [`b9864fd`](https://github.com/netblue30/firejail/commit/b9864fd46ff583e019314855b7194df11c8a1050) build: rename TOCLEAN and TODISTCLEAN variables - [`75587a4`](https://github.com/netblue30/firejail/commit/75587a4de41dbf0bdc8fabdd7b2c39e3a46613a8) build: standardize clean/distclean targets in src - [`7ff2d6b`](https://github.com/netblue30/firejail/commit/7ff2d6b50937dbaf58a1f28c1e5124e9a2fc59d6) build: line-wrap MANFLAGS - [`07b9414`](https://github.com/netblue30/firejail/commit/07b9414e2f5fca352c9911273e93fc3020311eb2) build: sort MANFLAGS and nearby variables - [`5801ce0`](https://github.com/netblue30/firejail/commit/5801ce05af92e3fc102395555ef94cfad2d1f5dc) build: split misc flags from MANFLAGS - [`cddf20f`](https://github.com/netblue30/firejail/commit/cddf20ff1e69c85715e65394388f4ce912c01789) build: remove redundant LDFLAGS in so.mk - [`9c08da1`](https://github.com/netblue30/firejail/commit/9c08da15bd18d5a131fef5d6937ad9103f20340d) build: move common CFLAGS/LDFLAGS first - [`0771612`](https://github.com/netblue30/firejail/commit/07716128b12346e60146404cbd5d3ec799708d1d) build: move remaining build flags into config.mk.in ### 📊 Changes **21 files changed** (+104 additions, -84 deletions) <details> <summary>View changed files</summary> 📝 `config.mk.in` (+62 -19) 📝 `src/etc-cleanup/Makefile` (+1 -1) 📝 `src/fbuilder/Makefile` (+1 -1) 📝 `src/fcopy/Makefile` (+2 -2) 📝 `src/fids/Makefile` (+1 -1) 📝 `src/firecfg/Makefile` (+2 -2) 📝 `src/firejail/Makefile` (+2 -2) 📝 `src/firemon/Makefile` (+2 -2) 📝 `src/fldd/Makefile` (+2 -2) 📝 `src/fnet/Makefile` (+2 -2) 📝 `src/fnetfilter/Makefile` (+2 -2) 📝 `src/fsec-optimize/Makefile` (+2 -2) 📝 `src/fsec-print/Makefile` (+2 -2) 📝 `src/fseccomp/Makefile` (+2 -2) 📝 `src/fzenity/Makefile` (+1 -1) 📝 `src/jailcheck/Makefile` (+2 -2) 📝 `src/libpostexecseccomp/Makefile` (+1 -1) 📝 `src/libtracelog/Makefile` (+1 -1) 📝 `src/profstats/Makefile` (+1 -1) 📝 `src/prog.mk` (+6 -20) _...and 1 more files_ </details> ### 📄 Description Main changes: * build: rename MOD vars to EXTRA vars * build: rename TOCLEAN and TODISTCLEAN variables * build: standardize clean/distclean targets in src * build: remove redundant LDFLAGS in so.mk * build: move remaining build flags into config.mk.in * build: standardize common CFLAGS --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:43:16 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5700

No description provided.

Rows
Columns