[PR #5850] [MERGED] contrib/vim: match profile files more broadly #5691

Closed
opened 2026-05-05 10:43:05 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5850
Author: @kmk3
Created: 6/9/2023
Status: Merged
Merged: 6/18/2023
Merged by: @kmk3

Base: masterHead: vim-improve-ftdetect


📝 Commits (2)

  • 2f87ae1 contrib/vim: sort paths in ftdetect
  • 6273865 contrib/vim: match profile files more broadly

📊 Changes

1 file changed (+10 additions, -4 deletions)

View changed files

📝 contrib/vim/ftdetect/firejail.vim (+10 -4)

📄 Description

Currently it only sets the appropriate filetype for files in
/etc/firejail and ~/.config/firejail.

With this commit, the firejail filetype should also be set when opening
etc/inc/*.inc, for example, as long as there is a "firejail" directory
somewhere before that (such as in /foo/firejail/bar/etc/inc/*.inc).

Note: At least */firejail/*.inc needs to force the match (by using
set filetype rather than setfiletype), or else the default vim
checks take precedence (and the filetype for all files in
etc/inc/*.inc gets set to pov).

Fixes #4319.

Relates to #2679.

Cc: @laomaiweng @reinerh @rusty-snake (from #2679 #4319)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5850 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 6/9/2023 **Status:** ✅ Merged **Merged:** 6/18/2023 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `vim-improve-ftdetect` --- ### 📝 Commits (2) - [`2f87ae1`](https://github.com/netblue30/firejail/commit/2f87ae148c510098ff7f6a186db5e1f360c9ca02) contrib/vim: sort paths in ftdetect - [`6273865`](https://github.com/netblue30/firejail/commit/6273865394760e9dbd522e5f348a837c8e02408a) contrib/vim: match profile files more broadly ### 📊 Changes **1 file changed** (+10 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `contrib/vim/ftdetect/firejail.vim` (+10 -4) </details> ### 📄 Description Currently it only sets the appropriate filetype for files in `/etc/firejail` and `~/.config/firejail`. With this commit, the firejail filetype should also be set when opening `etc/inc/*.inc`, for example, as long as there is a "firejail" directory somewhere before that (such as in `/foo/firejail/bar/etc/inc/*.inc`). Note: At least `*/firejail/*.inc` needs to force the match (by using `set filetype` rather than `setfiletype`), or else the default vim checks take precedence (and the filetype for all files in `etc/inc/*.inc` gets set to `pov`). Fixes #4319. Relates to #2679. Cc: @laomaiweng @reinerh @rusty-snake (from #2679 #4319) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 10:43:05 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5691
No description provided.