[PR #5806] [MERGED] bugfix: arp.c: ensure positive timeout on select(2) #5675

New issue

Closed

opened 2026-05-05 10:42:49 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:42:49 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5806
Author: @kmk3
Created: 4/26/2023
Status: ✅ Merged
Merged: 5/1/2023
Merged by: @topimiettinen

Base: master ← Head: fix-arp-negative-time

📝 Commits (1)

fe53f52 arp.c: ensure positive timeout on select(2)

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 src/firejail/arp.c (+5 -1)

📄 Description

Log from build_and_test[1]:

TESTING: network scan (net_scan.exp)
[...]

firejail /bin/bash
Child process initialized in 1704.83 ms
spawn /bin/bash
firejail --net=br0 --ip=10.10.20.60
runner@fv-az576-472:~/work/firejail/firejail/test/network$
<l/test/network$ firejail --net=br0 --ip=10.10.20.60
Reading profile /etc/firejail/default.profile
Reading profile /etc/firejail/disable-common.inc
Reading profile /etc/firejail/disable-programs.inc

** Note: you can use --noprofile to disable default.profile **

Error select: arp.c:202 arp_check: Invalid argument
runner@fv-az576-472:~/work/firejail/firejail/test/network$ TESTING ERROR 4

This "Invalid argument" error does not always happen, so I assume that
it may be due to a negative integer value in ts when calling select.

Misc: Found in #5805.

[1] https://github.com/netblue30/firejail/actions/runs/4806275219/jobs/8553597462

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5806 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 4/26/2023 **Status:** ✅ Merged **Merged:** 5/1/2023 **Merged by:** [@topimiettinen](https://github.com/topimiettinen) **Base:** `master` ← **Head:** `fix-arp-negative-time` --- ### 📝 Commits (1) - [`fe53f52`](https://github.com/netblue30/firejail/commit/fe53f527c14e0dd26a1793ae07a35e7827326dd9) arp.c: ensure positive timeout on select(2) ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/arp.c` (+5 -1) </details> ### 📄 Description Log from build_and_test[1]: TESTING: network scan (net_scan.exp) [...] firejail /bin/bash Child process initialized in 1704.83 ms spawn /bin/bash firejail --net=br0 --ip=10.10.20.60 runner@fv-az576-472:~/work/firejail/firejail/test/network$ <l/test/network$ firejail --net=br0 --ip=10.10.20.60 Reading profile /etc/firejail/default.profile Reading profile /etc/firejail/disable-common.inc Reading profile /etc/firejail/disable-programs.inc ** Note: you can use --noprofile to disable default.profile ** Error select: arp.c:202 arp_check: Invalid argument runner@fv-az576-472:~/work/firejail/firejail/test/network$ TESTING ERROR 4 This "Invalid argument" error does not always happen, so I assume that it may be due to a negative integer value in `ts` when calling select. Misc: Found in #5805. [1] https://github.com/netblue30/firejail/actions/runs/4806275219/jobs/8553597462 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:42:49 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5675

No description provided.

Rows
Columns