[PR #5668] [MERGED] build: deb: enable apparmor by default & remove deb-apparmor #5605

New issue

Closed

opened 2026-05-05 10:41:31 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:41:31 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5668
Author: @kmk3
Created: 2/17/2023
Status: ✅ Merged
Merged: 2/17/2023
Merged by: @netblue30

Base: master ← Head: build-deb-apparmor-default

📝 Commits (3)

9837161 ci: move --prefix configure arg first
89d45e6 ci: deb: remove redundant --prefix arguments
f33e452 build: deb: enable apparmor by default & remove deb-apparmor

📊 Changes

6 files changed (+12 additions, -16 deletions)

View changed files

📝 .github/workflows/build.yml (+1 -1)
📝 .gitlab-ci.yml (+8 -8)
📝 Makefile (+0 -4)
📝 README (+1 -1)
📝 contrib/update_deb.sh (+1 -1)
📝 mkdeb.sh (+1 -1)

📄 Description

The official .deb package is always built with apparmor support, so use
--enable-apparmor in mkdeb.sh and remove the "deb-apparmor" target in
order to reduce redundancy.

Note that custom configure options may be specified by calling
./mkdeb.sh directly.

For example, to build the .deb package without apparmor support, instead
of running make deb, the following commands can be used:

make dist
./mkdeb.sh --disable-apparmor

Also, change the build_apparmor GitLab CI job into
build_no_apparmor, which is intended to check that building without
apparmor still works.

Note: This commit makes the resulting .deb package not have an
"-apparmor" suffix (see EXTRA_VERSION in mkdeb.sh), to avoid
redundancy (as having apparmor support becomes the default).

Misc: This is a follow-up to #5654.

Relates to #5154 #5176 #5547.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5668 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 2/17/2023 **Status:** ✅ Merged **Merged:** 2/17/2023 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `build-deb-apparmor-default` --- ### 📝 Commits (3) - [`9837161`](https://github.com/netblue30/firejail/commit/983716184093a8f87e63735e743dde2309749e1e) ci: move --prefix configure arg first - [`89d45e6`](https://github.com/netblue30/firejail/commit/89d45e6cf246037cfe097d7bd3dddef1687d684b) ci: deb: remove redundant --prefix arguments - [`f33e452`](https://github.com/netblue30/firejail/commit/f33e452b044af0b651784a43e6981078eb0c0540) build: deb: enable apparmor by default & remove deb-apparmor ### 📊 Changes **6 files changed** (+12 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+1 -1) 📝 `.gitlab-ci.yml` (+8 -8) 📝 `Makefile` (+0 -4) 📝 `README` (+1 -1) 📝 `contrib/update_deb.sh` (+1 -1) 📝 `mkdeb.sh` (+1 -1) </details> ### 📄 Description The official .deb package is always built with apparmor support, so use `--enable-apparmor` in mkdeb.sh and remove the "deb-apparmor" target in order to reduce redundancy. Note that custom configure options may be specified by calling ./mkdeb.sh directly. For example, to build the .deb package without apparmor support, instead of running `make deb`, the following commands can be used: make dist ./mkdeb.sh --disable-apparmor Also, change the `build_apparmor` GitLab CI job into `build_no_apparmor`, which is intended to check that building without apparmor still works. Note: This commit makes the resulting .deb package not have an "-apparmor" suffix (see `EXTRA_VERSION` in mkdeb.sh), to avoid redundancy (as having apparmor support becomes the default). Misc: This is a follow-up to #5654. Relates to #5154 #5176 #5547. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:41:31 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5605

No description provided.

Rows
Columns