github-starred/firejail

Fork 0

mirror of https://github.com/netblue30/firejail.git synced 2026-05-15 14:16:14 -06:00

[PR #5667] [MERGED] legal: selinux.c: Split Copyright notice & use same license as upstream #5603

New issue

Closed

opened 2026-05-05 10:41:29 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:41:29 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5667
Author: @kmk3
Created: 2/16/2023
Status: ✅ Merged
Merged: 2/17/2023
Merged by: @netblue30

Base: master ← Head: selinux-c-change-notices

📝 Commits (2)

468c153 selinux.c: Split Copyright notice in two
901a5b5 selinux.c: Use same license as upstream file (LGPLv2.1+)

📊 Changes

1 file changed (+3 additions, -15 deletions)

View changed files

📝 src/firejail/selinux.c (+3 -15)

📄 Description

selinux.c: Split Copyright notice in two

This makes firejail's Copyright notice match the ones in basically
every other file, which simplifies updating the Copyright years.

selinux.c was added on commit 1ad2d54c0 ("Add support for SELinux
labeling", 2020-02-18) and it claims to be "from systemd
selinux-util.c".

As for systemd's Copyright notice, the current version of that file on
the systemd project does not have any[1].

The first commit in the systemd repository is from 2009[2] and the file
was copied in 2020 (and does not seem to have been synced since), so set
the years in its Copyright notice to 2009-2020.

Since there is no Copyright notice (and no author) in the upstream file,
list "The systemd Authors" in the Copyright notice.

See also systemd commit 0c69794138 ("tree-wide: remove Lennart's
copyright lines", 2018-06-12)[3] [4].

[1] 254d1313ae/src/shared/selinux-util.c
[2] 6091827530
[3] 0c69794138
[4] https://github.com/systemd/systemd/pull/9274

selinux.c: Use same license as upstream file (LGPLv2.1+)

The upstream file is licensed under the LGPLv2.1+ and it uses an SPDX
license identifier rather than an LGPL license notice[1].

And according to the GNU project, the LGPLv2.1+ is compatible with both
the GPLv2 (with the result being GPLv2) and the GPLv3 (with the result
being GPLv3), though the reverse (GPL -> LGPL) does not apply[2] [3].
This means that if we make changes that are only available under the
GPLv2, systemd would be unable to copy them back and release the result
under the LGPLv2.1 without being in violation of the GPLv2.

So replace the GPL license notice with the SPDX license identifier of
the upstream file ("LGPL-2.1-or-later"), to make it easier to share
changes between both projects.

See also the following systemd commits[4] [5] [6] [7]:

53e1b68390 ("Add SPDX license identifiers to source files under the
LGPL", 2017-11-18)
db9ecf0501 ("license: LGPL-2.1+ -> LGPL-2.1-or-later", 2020-11-09)

[1] 254d1313ae/src/shared/selinux-util.c
[2] https://www.gnu.org/licenses/license-list.en.html#LGPLv2.1
[3] https://www.gnu.org/licenses/license-compatibility.html
[4] 53e1b68390
[5] https://github.com/systemd/systemd/pull/7386
[6] db9ecf0501
[7] https://github.com/systemd/systemd/pull/17548

This is a follow-up to #5664.

Cc: @reinerh @smitsohu @topimiettinen (as contributors to selinux.c)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5667 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 2/16/2023 **Status:** ✅ Merged **Merged:** 2/17/2023 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `selinux-c-change-notices` --- ### 📝 Commits (2) - [`468c153`](https://github.com/netblue30/firejail/commit/468c153f70fc75f2e3fa19b55e3ec3c35a9e7ec6) selinux.c: Split Copyright notice in two - [`901a5b5`](https://github.com/netblue30/firejail/commit/901a5b581f3a29cd68577c8ce04aecfba2107903) selinux.c: Use same license as upstream file (LGPLv2.1+) ### 📊 Changes **1 file changed** (+3 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/selinux.c` (+3 -15) </details> ### 📄 Description selinux.c: Split Copyright notice in two This makes firejail's Copyright notice match the ones in basically every other file, which simplifies updating the Copyright years. selinux.c was added on commit 1ad2d54c0 ("Add support for SELinux labeling", 2020-02-18) and it claims to be "from systemd selinux-util.c". As for systemd's Copyright notice, the current version of that file on the systemd project does not have any[1]. The first commit in the systemd repository is from 2009[2] and the file was copied in 2020 (and does not seem to have been synced since), so set the years in its Copyright notice to 2009-2020. Since there is no Copyright notice (and no author) in the upstream file, list "The systemd Authors" in the Copyright notice. See also systemd commit 0c69794138 ("tree-wide: remove Lennart's copyright lines", 2018-06-12)[3] [4]. [1] https://github.com/systemd/systemd/blob/254d1313ae5a69c08c9b93032aaaf3d6083cfc07/src/shared/selinux-util.c [2] https://github.com/systemd/systemd/commit/6091827530d6dd43479d6709fb6e9f745c11e900 [3] https://github.com/systemd/systemd/commit/0c697941389b7379c4471bc0a067ede02814bc57 [4] https://github.com/systemd/systemd/pull/9274 --- selinux.c: Use same license as upstream file (LGPLv2.1+) The upstream file is licensed under the LGPLv2.1+ and it uses an SPDX license identifier rather than an LGPL license notice[1]. And according to the GNU project, the LGPLv2.1+ is compatible with both the GPLv2 (with the result being GPLv2) and the GPLv3 (with the result being GPLv3), though the reverse (GPL -> LGPL) does not apply[2] [3]. This means that if we make changes that are only available under the GPLv2, systemd would be unable to copy them back and release the result under the LGPLv2.1 without being in violation of the GPLv2. So replace the GPL license notice with the SPDX license identifier of the upstream file ("LGPL-2.1-or-later"), to make it easier to share changes between both projects. See also the following systemd commits[4] [5] [6] [7]: * 53e1b68390 ("Add SPDX license identifiers to source files under the LGPL", 2017-11-18) * db9ecf0501 ("license: LGPL-2.1+ -> LGPL-2.1-or-later", 2020-11-09) [1] https://github.com/systemd/systemd/blob/254d1313ae5a69c08c9b93032aaaf3d6083cfc07/src/shared/selinux-util.c [2] https://www.gnu.org/licenses/license-list.en.html#LGPLv2.1 [3] https://www.gnu.org/licenses/license-compatibility.html [4] https://github.com/systemd/systemd/commit/53e1b683907c2f12330f00feb9630150196f064d [5] https://github.com/systemd/systemd/pull/7386 [6] https://github.com/systemd/systemd/commit/db9ecf050165fd1033c6f81485917e229c4be537 [7] https://github.com/systemd/systemd/pull/17548 --- This is a follow-up to #5664. Cc: @reinerh @smitsohu @topimiettinen (as contributors to selinux.c) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:41:29 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5603

No description provided.

Rows
Columns