[PR #5654] [MERGED] build: mkdeb.sh: pass all arguments to ./configure #5594

New issue

Closed

opened 2026-05-05 10:41:19 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:41:19 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5654
Author: @kmk3
Created: 2/10/2023
Status: ✅ Merged
Merged: 2/14/2023
Merged by: @netblue30

Base: master ← Head: build-mkdeb-noargs

📝 Commits (1)

d4639bf build: mkdeb.sh: pass all arguments to ./configure

📊 Changes

2 files changed (+1 additions, -5 deletions)

View changed files

📝 Makefile (+1 -1)
📝 mkdeb.sh (+0 -4)

📄 Description

Instead of using the first argument as the EXTRA_VERSION variable.
This should make the usage of mkdeb.sh less confusing, especially when
one is not trying to set the variable.

As for using EXTRA_VERSION (which is still optional with this commit),
make sure that it is set as an environment variable before caling
mkdeb.sh. Example:

env EXTRA_VERSION=-apparmor ./mkdeb.sh --enable-apparmor

See also commit 9a0fbbd71 ("mkdeb.sh.in: pass remaining arguments to
./configure", 2022-05-13) / PR #5154.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5654 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 2/10/2023 **Status:** ✅ Merged **Merged:** 2/14/2023 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `build-mkdeb-noargs` --- ### 📝 Commits (1) - [`d4639bf`](https://github.com/netblue30/firejail/commit/d4639bfc4425c404841ff0cdc36bc05665c7986e) build: mkdeb.sh: pass all arguments to ./configure ### 📊 Changes **2 files changed** (+1 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+1 -1) 📝 `mkdeb.sh` (+0 -4) </details> ### 📄 Description Instead of using the first argument as the `EXTRA_VERSION` variable. This should make the usage of mkdeb.sh less confusing, especially when one is not trying to set the variable. As for using `EXTRA_VERSION` (which is still optional with this commit), make sure that it is set as an environment variable before caling mkdeb.sh. Example: env EXTRA_VERSION=-apparmor ./mkdeb.sh --enable-apparmor See also commit 9a0fbbd71 ("mkdeb.sh.in: pass remaining arguments to ./configure", 2022-05-13) / PR #5154. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:41:19 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5594

No description provided.

Rows
Columns