[PR #5627] [MERGED] build: auto-generate syntax files #5575

New issue

Closed

opened 2026-05-05 10:40:58 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:40:58 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5627
Author: @kmk3
Created: 1/28/2023
Status: ✅ Merged
Merged: 1/30/2023
Merged by: @netblue30

Base: master ← Head: build-autogen-syntax

📝 Commits (8)

cb65de5 ci: sort items on paths-ignore lists
4031155 build: run commands silently on config targets
fab6752 build: move man page targets to after seccomp filters
88ba851 build: move syntax files to contrib/syntax/files
c7c4f57 build: auto-generate syntax lists
aad1351 build: auto-generate syntax files
757e5f4 build: make contrib target by default
d30e709 build: sort with C locale when generating syntax lists

📊 Changes

16 files changed (+991 additions, -130 deletions)

View changed files

📝 .github/workflows/build-extra.yml (+4 -4)
📝 .github/workflows/codeql-analysis.yml (+4 -4)
📝 .gitignore (+3 -0)
📝 CONTRIBUTING.md (+1 -2)
📝 Makefile (+97 -13)
➕ contrib/syntax/files/example.in (+16 -0)
📝 contrib/syntax/files/firejail-profile.lang.in (+4 -3)
➕ contrib/syntax/files/firejail.vim.in (+99 -0)
➕ contrib/syntax/lists/profile_commands_arg0.list (+50 -0)
➕ contrib/syntax/lists/profile_commands_arg1.list (+76 -0)
➕ contrib/syntax/lists/profile_conditionals.list (+9 -0)
➕ contrib/syntax/lists/profile_macros.list (+10 -0)
➕ contrib/syntax/lists/syscall_groups.list (+29 -0)
➕ contrib/syntax/lists/syscalls.list (+454 -0)
➕ contrib/syntax/lists/system_errnos.list (+135 -0)
➖ contrib/vim/syntax/firejail.vim (+0 -104)

📄 Description

Main changes:

Use the commands from contrib/vim/syntax/firejail.vim to create
makefile targets to generate syntax lists in contrib/syntax/lists
Add contrib/syntax/files/example.in as an example of how to generate
syntax files
Generate and add the syntax lists, to make it easier to spot if they
are properly updated when a new command is added or if their recipes
also need changes
Add "syntax" and "contrib" makefile targets
Generate firejail.vim from firejail.vim.in
Generate firejail-profile.lang from firejail-profile.lang.in
Update the manual syntax file steps on the new command checklist on
CONTRIBUTING.md to use make syntax instead
Make contrib target by default

Relates to #2679 #5502 #5577 #5612.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5627 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 1/28/2023 **Status:** ✅ Merged **Merged:** 1/30/2023 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `build-autogen-syntax` --- ### 📝 Commits (8) - [`cb65de5`](https://github.com/netblue30/firejail/commit/cb65de5054c205e26131868725d33ce5aca4024a) ci: sort items on paths-ignore lists - [`4031155`](https://github.com/netblue30/firejail/commit/403115565351a5a4277d45b96b1c37a347f1d0b4) build: run commands silently on config targets - [`fab6752`](https://github.com/netblue30/firejail/commit/fab675241bde7946c2eebab4cff0145b8a8ccdac) build: move man page targets to after seccomp filters - [`88ba851`](https://github.com/netblue30/firejail/commit/88ba851893362dacdbde6ff9527675b07affff27) build: move syntax files to contrib/syntax/files - [`c7c4f57`](https://github.com/netblue30/firejail/commit/c7c4f57d13b0e5720ee672a1761663d739d0bffa) build: auto-generate syntax lists - [`aad1351`](https://github.com/netblue30/firejail/commit/aad1351ab111372232cbdd249a12a194b9884f7b) build: auto-generate syntax files - [`757e5f4`](https://github.com/netblue30/firejail/commit/757e5f4b258aad12bdc6a0ec9c0903297db030e2) build: make contrib target by default - [`d30e709`](https://github.com/netblue30/firejail/commit/d30e709b79ea774d4d24e6db712145e4c793066f) build: sort with C locale when generating syntax lists ### 📊 Changes **16 files changed** (+991 additions, -130 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build-extra.yml` (+4 -4) 📝 `.github/workflows/codeql-analysis.yml` (+4 -4) 📝 `.gitignore` (+3 -0) 📝 `CONTRIBUTING.md` (+1 -2) 📝 `Makefile` (+97 -13) ➕ `contrib/syntax/files/example.in` (+16 -0) 📝 `contrib/syntax/files/firejail-profile.lang.in` (+4 -3) ➕ `contrib/syntax/files/firejail.vim.in` (+99 -0) ➕ `contrib/syntax/lists/profile_commands_arg0.list` (+50 -0) ➕ `contrib/syntax/lists/profile_commands_arg1.list` (+76 -0) ➕ `contrib/syntax/lists/profile_conditionals.list` (+9 -0) ➕ `contrib/syntax/lists/profile_macros.list` (+10 -0) ➕ `contrib/syntax/lists/syscall_groups.list` (+29 -0) ➕ `contrib/syntax/lists/syscalls.list` (+454 -0) ➕ `contrib/syntax/lists/system_errnos.list` (+135 -0) ➖ `contrib/vim/syntax/firejail.vim` (+0 -104) </details> ### 📄 Description Main changes: * Use the commands from contrib/vim/syntax/firejail.vim to create makefile targets to generate syntax lists in contrib/syntax/lists * Add contrib/syntax/files/example.in as an example of how to generate syntax files * Generate and add the syntax lists, to make it easier to spot if they are properly updated when a new command is added or if their recipes also need changes * Add "syntax" and "contrib" makefile targets * Generate firejail.vim from firejail.vim.in * Generate firejail-profile.lang from firejail-profile.lang.in * Update the manual syntax file steps on the new command checklist on CONTRIBUTING.md to use `make syntax` instead * Make contrib target by default Relates to #2679 #5502 #5577 #5612. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:40:58 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5575

No description provided.

Rows
Columns