[PR #5589] [MERGED] docs: remove apparmor options in --help when building without apparmor support #5560

Closed
opened 2026-05-05 10:40:40 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5589
Author: @nya1
Created: 1/14/2023
Status: Merged
Merged: 1/18/2023
Merged by: @netblue30

Base: masterHead: fix/apparmor-invalid-command-line-option


📝 Commits (2)

  • ed16bdf chore: update readme with flag to enable apparmor on ./configure
  • 36eb222 refactor: do not show apparmor CLI options if app armor is not supported

📊 Changes

3 files changed (+4 additions, -2 deletions)

View changed files

📝 README (+1 -1)
📝 README.md (+1 -1)
📝 src/firejail/usage.c (+2 -0)

📄 Description

  • If apparmor is not supported, do not show the apparmor CLI options in the usage info, needed because if any --apparmor* flag is used but apparmor is unsupported, an invalid command line option error will be returned:
# (AppArmor support is disabled)
firejail --apparmor firefox
Error: invalid --apparmor command line option
  • Update readme with the correct apparmor enable flag to be used with ./configure

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5589 **Author:** [@nya1](https://github.com/nya1) **Created:** 1/14/2023 **Status:** ✅ Merged **Merged:** 1/18/2023 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `fix/apparmor-invalid-command-line-option` --- ### 📝 Commits (2) - [`ed16bdf`](https://github.com/netblue30/firejail/commit/ed16bdfdfd98d58c1aab31d17085834b13eea3c8) chore: update readme with flag to enable apparmor on ./configure - [`36eb222`](https://github.com/netblue30/firejail/commit/36eb222001ca2f53de9e15c5a59d8f2182a9b3e7) refactor: do not show apparmor CLI options if app armor is not supported ### 📊 Changes **3 files changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `README` (+1 -1) 📝 `README.md` (+1 -1) 📝 `src/firejail/usage.c` (+2 -0) </details> ### 📄 Description - If apparmor is not supported, do not show the apparmor CLI options in the usage info, needed because if any --apparmor* flag is used but apparmor is unsupported, an invalid command line option error will be returned: ``` # (AppArmor support is disabled) firejail --apparmor firefox Error: invalid --apparmor command line option ``` - Update readme with the correct apparmor enable flag to be used with ./configure --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 10:40:40 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5560
No description provided.