[PR #5578] [MERGED] modif: Prevent sandbox name from containing only digits #5556

New issue

Closed

opened 2026-05-05 10:40:35 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:40:35 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5578
Author: @layderv
Created: 1/9/2023
Status: ✅ Merged
Merged: 1/31/2023
Merged by: @netblue30

Base: master ← Head: master

📝 Commits (1)

4b68920 Prevent sandbox name from containing only digits

📊 Changes

3 files changed (+27 additions, -0 deletions)

View changed files

📝 src/firejail/main.c (+13 -0)
📝 src/firejail/profile.c (+13 -0)
📝 src/man/firejail.txt (+1 -0)

📄 Description

If I use only numbers for a name,firejail --ls=numbers / fails. Is this an actual bug? If you forbid only numbers in jails, I will close this PR. I can rework it to delete the if's around the lines I added. This commit seems to me like the fix that touches the fewest lines of code. I gave priority to extract_pid which should better find the jail if it exists, is it correct?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5578 **Author:** [@layderv](https://github.com/layderv) **Created:** 1/9/2023 **Status:** ✅ Merged **Merged:** 1/31/2023 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`4b68920`](https://github.com/netblue30/firejail/commit/4b6892092a77b61a0de485966a7561ec61c72928) Prevent sandbox name from containing only digits ### 📊 Changes **3 files changed** (+27 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/main.c` (+13 -0) 📝 `src/firejail/profile.c` (+13 -0) 📝 `src/man/firejail.txt` (+1 -0) </details> ### 📄 Description If I use only numbers for a name,`firejail --ls=numbers /` fails. Is this an actual bug? If you forbid only numbers in jails, I will close this PR. I can rework it to delete the `if`'s around the lines I added. This commit seems to me like the fix that touches the fewest lines of code. I gave priority to `extract_pid` which should better find the jail if it exists, is it correct? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:40:35 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5556

No description provided.

Rows
Columns