[PR #5547] [MERGED] Revert "remove make deb and use make deb-apparmor to build packages" #5537

New issue

Closed

opened 2026-05-05 10:40:16 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:40:16 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5547
Author: @kmk3
Created: 12/21/2022
Status: ✅ Merged
Merged: 12/21/2022
Merged by: @netblue30

Base: master ← Head: revert-remove-make-deb

📝 Commits (1)

3a368e5 Revert "remove make deb and use make deb-apparmor to build packages"

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 Makefile (+3 -0)

📄 Description

This reverts commit 8229944053.

The idea is to later enable building the .deb package with AppArmor by
default with make deb and to then remove make deb-apparmor (though
note that some ci changes might also be needed in tandem[1]). This
could potentially allow building a .deb package for all firejail
versions (including past and future ones) with just make deb.

Also, note that other options can be added/removed to the default deb
target (besides AppArmor-related ones), so ideally there would be only a
single deb target with all the desired options applied.

So instead of releasing a version without make deb and then
potentially adding it back and removing make deb-apparmor, just leave
the targets as is (considering the current release, 0.9.70) for now.

[1] https://github.com/netblue30/firejail/pull/5176#issuecomment-1146855467

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5547 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 12/21/2022 **Status:** ✅ Merged **Merged:** 12/21/2022 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `revert-remove-make-deb` --- ### 📝 Commits (1) - [`3a368e5`](https://github.com/netblue30/firejail/commit/3a368e58ee63d3aaa18d869cf3838cb857ba8c72) Revert "remove make deb and use make deb-apparmor to build packages" ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+3 -0) </details> ### 📄 Description This reverts commit 82299440533f54bd45bd5ec69136233c04028c15. The idea is to later enable building the .deb package with AppArmor by default with `make deb` and to then remove `make deb-apparmor` (though note that some ci changes might also be needed in tandem[1]). This could potentially allow building a .deb package for all firejail versions (including past and future ones) with just `make deb`. Also, note that other options can be added/removed to the default `deb` target (besides AppArmor-related ones), so ideally there would be only a single `deb` target with all the desired options applied. So instead of releasing a version without `make deb` and then potentially adding it back and removing `make deb-apparmor`, just leave the targets as is (considering the current release, 0.9.70) for now. [1] https://github.com/netblue30/firejail/pull/5176#issuecomment-1146855467 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:40:16 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5537

No description provided.

Rows
Columns