[PR #5451] [MERGED] docs: clarify that --appimage should appear before --profile #5492

New issue

Closed

opened 2026-05-05 10:39:27 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:39:27 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5451
Author: @kmk3
Created: 11/4/2022
Status: ✅ Merged
Merged: 11/20/2022
Merged by: @kmk3

Base: master ← Head: docs-clarify-appimage

📝 Commits (1)

f03d986 docs: clarify that --appimage should appear before --profile

📊 Changes

2 files changed (+19 additions, -7 deletions)

View changed files

📝 src/man/firejail-profile.txt (+7 -2)
📝 src/man/firejail.txt (+12 -5)

📄 Description

And fix the argument order in the examples to reflect that.

Background: The order in which these options appeared in the
documentation was inconsistent. src/man/firejail.txt used --appimage
before --profile and src/man/firejail-profile.txt used --profile before
--appimage. Then commit 44fefcac0 ("Make appimage examples consistent
with --appimage option short description", 2022-10-05) / PR #5402 was
made, which standardized on --profile before --appimage in both places.

But as mentioned by @rusty-snake[1], --appimage has be specified before
--profile in order for any ?HAS_APPIMAGE conditionals inside of the
profile to evaluate to true.

So change the documentation to use and recommend the latter form.

Also, add --quiet to one example to make it clear that --appimage does
not have to be the first option (nor the last option before --profile).

[1] https://github.com/netblue30/firejail/pull/5402#issuecomment-1274889618

Cc: @slowpeek (from #5402)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5451 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 11/4/2022 **Status:** ✅ Merged **Merged:** 11/20/2022 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `docs-clarify-appimage` --- ### 📝 Commits (1) - [`f03d986`](https://github.com/netblue30/firejail/commit/f03d98649788243d4f47b340858a08e8f0d0dc8c) docs: clarify that --appimage should appear before --profile ### 📊 Changes **2 files changed** (+19 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/man/firejail-profile.txt` (+7 -2) 📝 `src/man/firejail.txt` (+12 -5) </details> ### 📄 Description And fix the argument order in the examples to reflect that. Background: The order in which these options appeared in the documentation was inconsistent. src/man/firejail.txt used --appimage before --profile and src/man/firejail-profile.txt used --profile before --appimage. Then commit 44fefcac0 ("Make appimage examples consistent with --appimage option short description", 2022-10-05) / PR #5402 was made, which standardized on --profile before --appimage in both places. But as mentioned by @rusty-snake[1], --appimage has be specified before --profile in order for any `?HAS_APPIMAGE` conditionals inside of the profile to evaluate to true. So change the documentation to use and recommend the latter form. Also, add --quiet to one example to make it clear that --appimage does not have to be the first option (nor the last option before --profile). [1] https://github.com/netblue30/firejail/pull/5402#issuecomment-1274889618 Cc: @slowpeek (from #5402) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:39:27 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5492

No description provided.

Rows
Columns