[PR #5429] [MERGED] build: sort.py improvements #5486

New issue

Closed

opened 2026-05-05 10:39:17 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:39:17 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5429
Author: @kmk3
Created: 10/18/2022
Status: ✅ Merged
Merged: 11/23/2022
Merged by: @kmk3

Base: master ← Head: sort-py-improvements

📝 Commits (10+)

89880e9 sort.py: enumerate lines from 1
801a995 sort.py: pass the str.casefold function directly
b9c2843 sort.py: simplify "checking" message code
2a7cc2e sort.py: rename raw_items to original_items
aa17ca5 sort.py: rename protocols to original_protocols
adff09c sort.py: line-wrap and improve comments
8635858 sort.py: print errors to stderr
9bf4912 sort.py: print more standard error messages
b1bf9a8 sort.py: print usage if there are no arguments
c648adc sort.py: use script name in usage/main docstring

📊 Changes

1 file changed (+56 additions, -35 deletions)

View changed files

📝 contrib/sort.py (+56 -35)

📄 Description

$ git log --reverse --pretty='* %s' master..
* sort.py: enumerate lines from 1
* sort.py: pass the str.casefold function directly
* sort.py: simplify "checking" message code
* sort.py: rename raw_items to original_items
* sort.py: rename protocols to original_protocols
* sort.py: line-wrap and improve comments
* sort.py: print errors to stderr
* sort.py: print more standard error messages

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5429 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 10/18/2022 **Status:** ✅ Merged **Merged:** 11/23/2022 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `sort-py-improvements` --- ### 📝 Commits (10+) - [`89880e9`](https://github.com/netblue30/firejail/commit/89880e96b9c54af5dc5b6322c22a75acd1267df8) sort.py: enumerate lines from 1 - [`801a995`](https://github.com/netblue30/firejail/commit/801a9951fefd004b6b6b549a3c4bd41e64a8f500) sort.py: pass the str.casefold function directly - [`b9c2843`](https://github.com/netblue30/firejail/commit/b9c2843111cd208ef40b2683e64edd2d6059c28f) sort.py: simplify "checking" message code - [`2a7cc2e`](https://github.com/netblue30/firejail/commit/2a7cc2e7ad1aaff6ccb4d8b6ac5de0bc0121d6ee) sort.py: rename raw_items to original_items - [`aa17ca5`](https://github.com/netblue30/firejail/commit/aa17ca5fc9b251cac33e8e48ac539e534c8c3c74) sort.py: rename protocols to original_protocols - [`adff09c`](https://github.com/netblue30/firejail/commit/adff09c6dbec927374f9eabe999a43f17e730f8b) sort.py: line-wrap and improve comments - [`8635858`](https://github.com/netblue30/firejail/commit/863585842993f8a64c782254e011bb268a452d4e) sort.py: print errors to stderr - [`9bf4912`](https://github.com/netblue30/firejail/commit/9bf491212a8887e940ce9f272e107830e47dfc9d) sort.py: print more standard error messages - [`b1bf9a8`](https://github.com/netblue30/firejail/commit/b1bf9a81033d7fbe413ee817c6da61ad567fbe3e) sort.py: print usage if there are no arguments - [`c648adc`](https://github.com/netblue30/firejail/commit/c648adc9a6e2f50e3b742d2f71a148e9f9e41c89) sort.py: use script name in usage/main docstring ### 📊 Changes **1 file changed** (+56 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `contrib/sort.py` (+56 -35) </details> ### 📄 Description ```console $ git log --reverse --pretty='* %s' master.. * sort.py: enumerate lines from 1 * sort.py: pass the str.casefold function directly * sort.py: simplify "checking" message code * sort.py: rename raw_items to original_items * sort.py: rename protocols to original_protocols * sort.py: line-wrap and improve comments * sort.py: print errors to stderr * sort.py: print more standard error messages ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>