[PR #5370] [MERGED] build: Remove deprecated syntax and modernize shell test scripts #5466

New issue

Closed

opened 2026-05-05 10:38:55 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:38:55 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5370
Author: @a1346054
Created: 9/13/2022
Status: ✅ Merged
Merged: 9/26/2022
Merged by: @netblue30

Base: master ← Head: fixes

📝 Commits (9)

4157640 tests: fix unintentional overwriting of array value
e04d6b7 tests: directly test for presence of command
d7826c2 tests: use an array
c47ad8b tests: fix underquoting
77d1ad3 tests: add missing final newline
270f0d9 tests: stop mixing tabs and spaces
7a5c2b2 tests: use bash-style ... instead of [...]
4d1fb9a tests: use bash-builtin instead of external seq
65a6b84 tests: remove stray ;

📊 Changes

24 files changed (+278 additions, -324 deletions)

View changed files

📝 contrib/gdb-firejail.sh (+1 -1)
📝 test/appimage/appimage.sh (+1 -1)
📝 test/apps-x11-xorg/apps-x11-xorg.sh (+4 -8)
📝 test/apps-x11/apps-x11.sh (+17 -27)
📝 test/apps/apps.sh (+3 -5)
📝 test/chroot/chroot.sh (+0 -2)
📝 test/compile/compile.sh (+47 -48)
📝 test/environment/environment.sh (+10 -14)
📝 test/environment/output.sh (+3 -3)
📝 test/fcopy/fcopy.sh (+2 -2)
📝 test/features/test.sh (+42 -45)
📝 test/filters/filters.sh (+38 -39)
📝 test/fnetfilter/fnetfilter.sh (+1 -1)
📝 test/fs/fs.sh (+14 -14)
📝 test/overlay/overlay.sh (+9 -15)
📝 test/private-lib/private-lib.sh (+3 -5)
📝 test/profiles/all-profiles.sh (+4 -4)
📝 test/profiles/profiles.sh (+4 -4)
📝 test/root/root.sh (+10 -11)
📝 test/stress/stress.sh (+1 -1)

...and 4 more files

📄 Description

I performed the minimum number of changes that still preserves the same old behavior, but fixes some errors and other minor issues.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5370 **Author:** [@a1346054](https://github.com/a1346054) **Created:** 9/13/2022 **Status:** ✅ Merged **Merged:** 9/26/2022 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `fixes` --- ### 📝 Commits (9) - [`4157640`](https://github.com/netblue30/firejail/commit/4157640007085152633a3a8800fd763fff9da523) tests: fix unintentional overwriting of array value - [`e04d6b7`](https://github.com/netblue30/firejail/commit/e04d6b7bf58a95105a8fc79fcde7c0e98875e72a) tests: directly test for presence of command - [`d7826c2`](https://github.com/netblue30/firejail/commit/d7826c2384b6aa655d92b0570bebdc9cef8cb393) tests: use an array - [`c47ad8b`](https://github.com/netblue30/firejail/commit/c47ad8b82a52a5648bdabfd8713ba0dda3df2c16) tests: fix underquoting - [`77d1ad3`](https://github.com/netblue30/firejail/commit/77d1ad3837ad7250544e4dd28070ba799cab340f) tests: add missing final newline - [`270f0d9`](https://github.com/netblue30/firejail/commit/270f0d95e3f27445057981b26a2aa6474769f3f2) tests: stop mixing tabs and spaces - [`7a5c2b2`](https://github.com/netblue30/firejail/commit/7a5c2b205e4f0c3700f41f2ccd2b104476b8f026) tests: use bash-style [[...]] instead of [...] - [`4d1fb9a`](https://github.com/netblue30/firejail/commit/4d1fb9af6e4194099b15c29ed7a70885415774d6) tests: use bash-builtin instead of external `seq` - [`65a6b84`](https://github.com/netblue30/firejail/commit/65a6b84f09942a626cafb103583457d89f5629d5) tests: remove stray ; ### 📊 Changes **24 files changed** (+278 additions, -324 deletions) <details> <summary>View changed files</summary> 📝 `contrib/gdb-firejail.sh` (+1 -1) 📝 `test/appimage/appimage.sh` (+1 -1) 📝 `test/apps-x11-xorg/apps-x11-xorg.sh` (+4 -8) 📝 `test/apps-x11/apps-x11.sh` (+17 -27) 📝 `test/apps/apps.sh` (+3 -5) 📝 `test/chroot/chroot.sh` (+0 -2) 📝 `test/compile/compile.sh` (+47 -48) 📝 `test/environment/environment.sh` (+10 -14) 📝 `test/environment/output.sh` (+3 -3) 📝 `test/fcopy/fcopy.sh` (+2 -2) 📝 `test/features/test.sh` (+42 -45) 📝 `test/filters/filters.sh` (+38 -39) 📝 `test/fnetfilter/fnetfilter.sh` (+1 -1) 📝 `test/fs/fs.sh` (+14 -14) 📝 `test/overlay/overlay.sh` (+9 -15) 📝 `test/private-lib/private-lib.sh` (+3 -5) 📝 `test/profiles/all-profiles.sh` (+4 -4) 📝 `test/profiles/profiles.sh` (+4 -4) 📝 `test/root/root.sh` (+10 -11) 📝 `test/stress/stress.sh` (+1 -1) _...and 4 more files_ </details> ### 📄 Description I performed the minimum number of changes that still preserves the same old behavior, but fixes some errors and other minor issues. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:38:55 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:39:38 -06:00

[PR #5467] [MERGED] Add support for cinelerra-gg #5504

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5466

No description provided.

Rows
Columns