[PR #5310] [MERGED] build: add and use TARNAME instead of NAME for paths #5440

New issue

Closed

opened 2026-05-05 10:38:27 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:38:27 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5310
Author: @kmk3
Created: 8/12/2022
Status: ✅ Merged
Merged: 8/14/2022
Merged by: @netblue30

Base: master ← Head: build-use-tarname

📝 Commits (5)

0d20026 config.mk.in: move CC variable near CFLAGS
3bb8064 config.mk.in: move basic variables to the top
9a45c34 build: rename DOCDIR to docdir
891fd02 build: add new TARNAME variable
7bbcf7e build: use TARNAME instead of NAME for paths

📊 Changes

4 files changed (+22 additions, -19 deletions)

View changed files

📝 Makefile (+12 -12)
📝 config.mk.in (+7 -5)
📝 config.sh.in (+1 -0)
📝 mkdeb.sh (+2 -2)

📄 Description

PACKAGE_TARNAME is the same as PACKAGE_NAME but normalized, so it should
be safer to use in paths. For example, on a downstream project, if
spaces or shell metacharacters are added to the package name, a path
that uses PACKAGE_TARNAME should keep working.

From the manual of GNU Autoconf (version 2.69):

-- Macro: AC_INIT (PACKAGE, VERSION, [BUG-REPORT], [TARNAME], [URL])
Process any command-line arguments and perform initialization and
verification.

 Set the name of the PACKAGE and its VERSION.  These are typically
 used in '--version' support, including that of 'configure'.  The
 optional argument BUG-REPORT should be the email to which users
 should send bug reports.  The package TARNAME differs from
 PACKAGE: the latter designates the full package name (e.g., 'GNU
 Autoconf'), while the former is meant for distribution tar ball
 names (e.g., 'autoconf').  It defaults to PACKAGE with 'GNU '
 stripped, lower-cased, and all characters other than
 alphanumerics and underscores are changed to '-'.

Note also that by default (on autoconf v2.69), DOCDIR=@docdir@ in
config.mk.in expands to the following in config.mk:

DOCDIR=${datarootdir}/doc/${PACKAGE_TARNAME}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5310 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 8/12/2022 **Status:** ✅ Merged **Merged:** 8/14/2022 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `build-use-tarname` --- ### 📝 Commits (5) - [`0d20026`](https://github.com/netblue30/firejail/commit/0d200264b1bc04304ae5dcb70f8bcc7ae3b358cc) config.mk.in: move CC variable near CFLAGS - [`3bb8064`](https://github.com/netblue30/firejail/commit/3bb8064677f1ca423447a47da1265ea67512b03d) config.mk.in: move basic variables to the top - [`9a45c34`](https://github.com/netblue30/firejail/commit/9a45c34fc762b1d52d48ea3886b7b09f0b769c74) build: rename DOCDIR to docdir - [`891fd02`](https://github.com/netblue30/firejail/commit/891fd0270154ba1992e30d3e59c1daf990bfb604) build: add new TARNAME variable - [`7bbcf7e`](https://github.com/netblue30/firejail/commit/7bbcf7eab290c8b9f683f71838009933df2295b5) build: use TARNAME instead of NAME for paths ### 📊 Changes **4 files changed** (+22 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+12 -12) 📝 `config.mk.in` (+7 -5) 📝 `config.sh.in` (+1 -0) 📝 `mkdeb.sh` (+2 -2) </details> ### 📄 Description PACKAGE_TARNAME is the same as PACKAGE_NAME but normalized, so it should be safer to use in paths. For example, on a downstream project, if spaces or shell metacharacters are added to the package name, a path that uses PACKAGE_TARNAME should keep working. From the manual of GNU Autoconf (version 2.69): > -- Macro: AC_INIT (PACKAGE, VERSION, [BUG-REPORT], [TARNAME], [URL]) > Process any command-line arguments and perform initialization and > verification. > > Set the name of the PACKAGE and its VERSION. These are typically > used in '--version' support, including that of 'configure'. The > optional argument BUG-REPORT should be the email to which users > should send bug reports. The package TARNAME differs from > PACKAGE: the latter designates the full package name (e.g., 'GNU > Autoconf'), while the former is meant for distribution tar ball > names (e.g., 'autoconf'). It defaults to PACKAGE with 'GNU ' > stripped, lower-cased, and all characters other than > alphanumerics and underscores are changed to '-'. Note also that by default (on autoconf v2.69), `DOCDIR=@docdir@` in config.mk.in expands to the following in config.mk: DOCDIR=${datarootdir}/doc/${PACKAGE_TARNAME} --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:38:27 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:40:06 -06:00

[PR #5537] [MERGED] add restrict-namespaces to (almost) all applicable profiles #5529

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5440

No description provided.

Rows
Columns