[PR #5284] [MERGED] build: config.sh.in: quote variables and fix shellcheck issues #5427

New issue

Closed

opened 2026-05-05 10:38:15 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:38:15 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5284
Author: @kmk3
Created: 8/1/2022
Status: ✅ Merged
Merged: 8/11/2022
Merged by: @kmk3

Base: master ← Head: build-config-sh-fixes

📝 Commits (2)

f1f40cb config.sh.in: quote all variables
f08c378 config.sh.in: fix all issues reported by shellcheck

📊 Changes

1 file changed (+6 additions, -2 deletions)

View changed files

📝 config.sh.in (+6 -2)

📄 Description

config.sh.in: quote all variables

Output variables in general may contain values with spaces in them.
Example: CC=gcc -foo.

config.sh.in: fix all issues reported by shellcheck

Fix the following error and warnings:

$ shellcheck --version | grep ^version:
version: 0.8.0
$ shellcheck config.sh.in

In config.sh.in line 1:
# @configure_input@
^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.

In config.sh.in line 3:
NAME=@PACKAGE_NAME@
^--^ SC2034 (warning): NAME appears unused. Verify use (or export if used externally).

In config.sh.in line 4:
VERSION=@PACKAGE_VERSION@
^-----^ SC2034 (warning): VERSION appears unused. Verify use (or export if used externally).

For more information:
  https://www.shellcheck.net/wiki/SC2148 -- Tips depend on target shell and y...
  https://www.shellcheck.net/wiki/SC2034 -- NAME appears unused. Verify use (...

Relates to #5140.

Kind of relates to #5251.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5284 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 8/1/2022 **Status:** ✅ Merged **Merged:** 8/11/2022 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `build-config-sh-fixes` --- ### 📝 Commits (2) - [`f1f40cb`](https://github.com/netblue30/firejail/commit/f1f40cbaa3f3e76eff655e3081181e08a7157e74) config.sh.in: quote all variables - [`f08c378`](https://github.com/netblue30/firejail/commit/f08c378d5a837ee803c74a4a6b70c84e6e010136) config.sh.in: fix all issues reported by shellcheck ### 📊 Changes **1 file changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `config.sh.in` (+6 -2) </details> ### 📄 Description config.sh.in: quote all variables Output variables in general may contain values with spaces in them. Example: `CC=gcc -foo`. --- config.sh.in: fix all issues reported by shellcheck Fix the following error and warnings: $ shellcheck --version | grep ^version: version: 0.8.0 $ shellcheck config.sh.in In config.sh.in line 1: # @configure_input@ ^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. In config.sh.in line 3: NAME=@PACKAGE_NAME@ ^--^ SC2034 (warning): NAME appears unused. Verify use (or export if used externally). In config.sh.in line 4: VERSION=@PACKAGE_VERSION@ ^-----^ SC2034 (warning): VERSION appears unused. Verify use (or export if used externally). For more information: https://www.shellcheck.net/wiki/SC2148 -- Tips depend on target shell and y... https://www.shellcheck.net/wiki/SC2034 -- NAME appears unused. Verify use (... --- Relates to #5140. Kind of relates to #5251. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:38:15 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5427

No description provided.

Rows
Columns