[PR #5182] [MERGED] Revert "Makefile.in: stop running distclean on dist" #5396

New issue

Closed

opened 2026-05-05 10:37:38 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:37:38 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5182
Author: @kmk3
Created: 6/8/2022
Status: ✅ Merged
Merged: 6/8/2022
Merged by: @netblue30

Base: master ← Head: revert-stop-distclean-on-dist

📝 Commits (1)

56b86f8 Revert "Makefile.in: stop running distclean on dist"

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 Makefile.in (+5 -0)

📄 Description

This reverts commit 1fb814e511.

If distclean is not executed before copying the files on dist, then the
generated files inside src/ are included in the dist archive:

$ ./configure >/dev/null && make distclean >/dev/null &&
  ./configure >/dev/null && make dist | grep 'Makefile$' | wc -l
26

This happens because src/ is copied wholesale on dist (see DISTFILES).
Revert the commit to ensure that only the input files (such as the
"Makefile.in" files) are archived.

Relates to #5142.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5182 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 6/8/2022 **Status:** ✅ Merged **Merged:** 6/8/2022 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `revert-stop-distclean-on-dist` --- ### 📝 Commits (1) - [`56b86f8`](https://github.com/netblue30/firejail/commit/56b86f8ace0962bc5e8f59a15c4ff423c80e4f9b) Revert "Makefile.in: stop running distclean on dist" ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `Makefile.in` (+5 -0) </details> ### 📄 Description This reverts commit 1fb814e51149d105233f1edc1abb0de202f71b4d. If distclean is not executed before copying the files on dist, then the generated files inside src/ are included in the dist archive: $ ./configure >/dev/null && make distclean >/dev/null && ./configure >/dev/null && make dist | grep 'Makefile$' | wc -l 26 This happens because src/ is copied wholesale on dist (see DISTFILES). Revert the commit to ensure that only the input files (such as the "Makefile.in" files) are archived. Related discussion: https://github.com/netblue30/firejail/pull/5154#pullrequestreview-980810845 Relates to #5142. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:37:38 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5396

No description provided.

Rows
Columns