[PR #5147] [MERGED] ci: fix --version not printing compile-time features #5380

Closed
opened 2026-05-05 10:37:22 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5147
Author: @kmk3
Created: 5/17/2022
Status: Merged
Merged: 5/17/2022
Merged by: @kmk3

Base: masterHead: ci-fix-print-version


📝 Commits (1)

  • 78aaed1 ci: fix --version not printing compile-time features

📊 Changes

3 files changed (+9 additions, -5 deletions)

View changed files

📝 src/firejail/checkcfg.c (+6 -0)
📝 src/firejail/firejail.h (+1 -0)
📝 src/firejail/main.c (+2 -5)

📄 Description

Currently, when running on CI, firejail --version only prints the
following line:

firejail version 0.9.69

Add a new print_version() function that always prints both the above and
the compile-time options (like it is done outside of CI) and call it in
both of the places that handle --version on main.c.

Misc: The printing of compile-time features was added on commit
48dd1fbec ("apparmor", 2016-08-02).


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5147 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 5/17/2022 **Status:** ✅ Merged **Merged:** 5/17/2022 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `ci-fix-print-version` --- ### 📝 Commits (1) - [`78aaed1`](https://github.com/netblue30/firejail/commit/78aaed11d85be690204fbd956732a7c1f18363e3) ci: fix --version not printing compile-time features ### 📊 Changes **3 files changed** (+9 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/checkcfg.c` (+6 -0) 📝 `src/firejail/firejail.h` (+1 -0) 📝 `src/firejail/main.c` (+2 -5) </details> ### 📄 Description Currently, when running on CI, `firejail --version` only prints the following line: firejail version 0.9.69 Add a new print_version() function that always prints both the above and the compile-time options (like it is done outside of CI) and call it in both of the places that handle --version on main.c. Misc: The printing of compile-time features was added on commit 48dd1fbec ("apparmor", 2016-08-02). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 10:37:22 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5380
No description provided.