[PR #5142] [MERGED] Makefile.in: stop running distclean on dist #5377

New issue

Closed

opened 2026-05-05 10:37:21 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:37:21 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5142
Author: @kmk3
Created: 5/13/2022
Status: ✅ Merged
Merged: 5/19/2022
Merged by: @kmk3

Base: master ← Head: stop-distclean-on-dist

📝 Commits (1)

1fb814e Makefile.in: stop running distclean on dist

📊 Changes

1 file changed (+0 additions, -5 deletions)

View changed files

📝 Makefile.in (+0 -5)

📄 Description

distclean erases user-made modifications to the files generated by the
configure script; it is not obvious that a non-"clean" target would ever
run it.

That is, instead of:

./configure --enable-foo && make distclean && make dist

It would probably be safer (and more maintainable) to do:

make distclean && ./configure --enable-foo && make dist

So drop the distclean call and the file-moving hacks around it.

Added on commit 137985136 ("Baseline firejail 0.9.28", 2015-08-08).

Relates to commit 684919100 ("bug: preserve config.status during make
dist", 2016-09-19) and commit 31dc1218a ("fixups", 2020-07-19).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5142 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 5/13/2022 **Status:** ✅ Merged **Merged:** 5/19/2022 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `stop-distclean-on-dist` --- ### 📝 Commits (1) - [`1fb814e`](https://github.com/netblue30/firejail/commit/1fb814e51149d105233f1edc1abb0de202f71b4d) Makefile.in: stop running distclean on dist ### 📊 Changes **1 file changed** (+0 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `Makefile.in` (+0 -5) </details> ### 📄 Description distclean erases user-made modifications to the files generated by the configure script; it is not obvious that a non-"clean" target would ever run it. That is, instead of: ./configure --enable-foo && make distclean && make dist It would probably be safer (and more maintainable) to do: make distclean && ./configure --enable-foo && make dist So drop the distclean call and the file-moving hacks around it. Added on commit 137985136 ("Baseline firejail 0.9.28", 2015-08-08). Relates to commit 684919100 ("bug: preserve config.status during make dist", 2016-09-19) and commit 31dc1218a ("fixups", 2020-07-19). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:37:21 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:39:01 -06:00

[PR #5377] [MERGED] RELNOTES: dedup/reword/sort/add #5471

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5377

No description provided.

Rows
Columns