github-starred/firejail

Fork 0

mirror of https://github.com/netblue30/firejail.git synced 2026-05-15 14:16:14 -06:00

[PR #5133] [MERGED] configure*: remove ultimately unused INSTALL and RANLIB check macros #5374

New issue

Closed

opened 2026-05-05 10:37:17 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:37:17 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5133
Author: @kmk3
Created: 5/7/2022
Status: ✅ Merged
Merged: 5/8/2022
Merged by: @reinerh

Base: master ← Head: configure-rm-unused-macros

📝 Commits (1)

d2a7b3a configure*: remove ultimately unused INSTALL and RANLIB check macros

📊 Changes

2 files changed (+0 additions, -226 deletions)

View changed files

📝 configure (+0 -224)
📝 configure.ac (+0 -2)

📄 Description

From the manual of GNU Autoconf (version 2.69):

-- Macro: AC_PROG_INSTALL
Set output variable 'INSTALL' to the name of a BSD-compatible
'install' program, if one is found in the current 'PATH'.
Otherwise, set 'INSTALL' to 'DIR/install-sh -c', checking the
directories specified to 'AC_CONFIG_AUX_DIR' (or its default
directories) to determine DIR (*note Output::). Also set the
variables 'INSTALL_PROGRAM' and 'INSTALL_SCRIPT' to '${INSTALL}'
and 'INSTALL_DATA' to '${INSTALL} -m 644'.

-- Macro: AC_PROG_RANLIB
Set output variable 'RANLIB' to 'ranlib' if 'ranlib' is found,
and otherwise to ':' (do nothing).

None of the aforementioned variables are used:

$ git grep -F -e '${INSTALL}' -e INSTALL_PROGRAM -e INSTALL_SCRIPT \
  -e INSTALL_DATA -e RANLIB
$

So remove the macros that define them.

Misc: The macros in question have been present on configure.ac since it
was created, on commit 137985136 ("Baseline firejail 0.9.28",
2015-08-08). And while the install command is called multiple times,
ranlib is not used anywhere (and it seems that it was never used):

$ git grep -E '^[[:blank:]]+install ' -- '*Makefile*' '*.mk*' |
  wc -l
32
$ git grep -F ranlib | wc -l
0
$ git log --pretty= --name-only -G'RANLIB|ranlib' \
  137985136..master | sort -u
README.md

Kind of relates to #4695.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5133 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 5/7/2022 **Status:** ✅ Merged **Merged:** 5/8/2022 **Merged by:** [@reinerh](https://github.com/reinerh) **Base:** `master` ← **Head:** `configure-rm-unused-macros` --- ### 📝 Commits (1) - [`d2a7b3a`](https://github.com/netblue30/firejail/commit/d2a7b3a65c633a9fd114aeb016f0c49ae9cbad5a) configure*: remove ultimately unused INSTALL and RANLIB check macros ### 📊 Changes **2 files changed** (+0 additions, -226 deletions) <details> <summary>View changed files</summary> 📝 `configure` (+0 -224) 📝 `configure.ac` (+0 -2) </details> ### 📄 Description From the manual of GNU Autoconf (version 2.69): > -- Macro: AC_PROG_INSTALL > Set output variable 'INSTALL' to the name of a BSD-compatible > 'install' program, if one is found in the current 'PATH'. > Otherwise, set 'INSTALL' to 'DIR/install-sh -c', checking the > directories specified to 'AC_CONFIG_AUX_DIR' (or its default > directories) to determine DIR (*note Output::). Also set the > variables 'INSTALL_PROGRAM' and 'INSTALL_SCRIPT' to '${INSTALL}' > and 'INSTALL_DATA' to '${INSTALL} -m 644'. > -- Macro: AC_PROG_RANLIB > Set output variable 'RANLIB' to 'ranlib' if 'ranlib' is found, > and otherwise to ':' (do nothing). None of the aforementioned variables are used: $ git grep -F -e '${INSTALL}' -e INSTALL_PROGRAM -e INSTALL_SCRIPT \ -e INSTALL_DATA -e RANLIB $ So remove the macros that define them. Misc: The macros in question have been present on configure.ac since it was created, on commit 137985136 ("Baseline firejail 0.9.28", 2015-08-08). And while the install command is called multiple times, ranlib is not used anywhere (and it seems that it was never used): $ git grep -E '^[[:blank:]]+install ' -- '*Makefile*' '*.mk*' | wc -l 32 $ git grep -F ranlib | wc -l 0 $ git log --pretty= --name-only -G'RANLIB|ranlib' \ 137985136..master | sort -u README.md Kind of relates to #4695. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:37:17 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:38:59 -06:00

[PR #5374] [MERGED] profiles: arduino: allow devel paths #5467

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5374

No description provided.

Rows
Columns