[PR #5114] [MERGED] Stop warning on safe supplementary group clean #5365

New issue

Closed

opened 2026-05-05 10:37:06 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:37:06 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5114
Author: @kmk3
Created: 4/22/2022
Status: ✅ Merged
Merged: 4/25/2022
Merged by: @netblue30

Base: master ← Head: stop-warn-group-clean

📝 Commits (1)

30c1534 Stop warning on safe supplementary group clean

📊 Changes

1 file changed (+9 additions, -3 deletions)

View changed files

📝 src/firejail/util.c (+9 -3)

📄 Description

When nogroups is used, the following warning may be issued (potentially
multiple times, as drop_privs may be called more than once):

Warning: cleaning all supplementary groups

But the warning is being shown even when it seems that all supplementary
groups can be safely dropped (and are thus dropped), which is likely a
common scenario. This commit prevents the warning from being printed in
that case, making it so that it is only shown in the non-happy paths (as
was the case on firejail 0.9.66).

Misc: The added code was copied from drop_privs.

This amends commit 7abce0b4c ("Fix keeping certain groups with
nogroups", 2021-11-30) / PR #4732.

Kind of relates to #4930.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5114 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 4/22/2022 **Status:** ✅ Merged **Merged:** 4/25/2022 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `stop-warn-group-clean` --- ### 📝 Commits (1) - [`30c1534`](https://github.com/netblue30/firejail/commit/30c15348344b9fc6b33eac154611474ed7a41273) Stop warning on safe supplementary group clean ### 📊 Changes **1 file changed** (+9 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/util.c` (+9 -3) </details> ### 📄 Description When nogroups is used, the following warning may be issued (potentially multiple times, as drop_privs may be called more than once): Warning: cleaning all supplementary groups But the warning is being shown even when it seems that all supplementary groups can be safely dropped (and are thus dropped), which is likely a common scenario. This commit prevents the warning from being printed in that case, making it so that it is only shown in the non-happy paths (as was the case on firejail 0.9.66). Misc: The added code was copied from drop_privs. This amends commit 7abce0b4c ("Fix keeping certain groups with nogroups", 2021-11-30) / PR #4732. Kind of relates to #4930. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:37:06 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:39:00 -06:00

[PR #5371] [MERGED] profiles: allow perl/exiftool on the relevant profiles #5469

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5365

No description provided.

Rows
Columns