[PR #5058] [MERGED] Node.js stack refactoring #5349

New issue

Closed

opened 2026-05-05 10:36:49 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:36:49 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5058
Author: @ghost
Created: 3/20/2022
Status: ✅ Merged
Merged: 3/24/2022
Merged by: @netblue30

Base: master ← Head: nodejs-nvm

📝 Commits (10+)

b1c2d2a allow-nodejs.inc: add nvm support
76c9668 curl: add nvm support comment
8012fef nvm: remove profile
713249c sha256sum: add nvm support comment
d96cf4c tar: add nvm support comment
d09d1dc webstorm: fix ordering
114e4eb webui-aria2: add nvm support
538050b wget: add nvm support comment
bc185a9 nodejs-common: add comment & minor hardening
ee8c57e Create node-gyp.profile

📊 Changes

11 files changed (+53 additions, -8 deletions)

View changed files

📝 etc/inc/allow-nodejs.inc (+2 -0)
📝 etc/profile-a-l/curl.profile (+4 -0)
📝 etc/profile-m-z/node-gyp.profile (+3 -5)
📝 etc/profile-m-z/nodejs-common.profile (+10 -2)
➕ etc/profile-m-z/npx.profile (+11 -0)
➕ etc/profile-m-z/semver.profile (+11 -0)
📝 etc/profile-m-z/sha256sum.profile (+3 -0)
📝 etc/profile-m-z/tar.profile (+3 -0)
📝 etc/profile-m-z/webstorm.profile (+1 -1)
📝 etc/profile-m-z/webui-aria2.profile (+1 -0)
📝 etc/profile-m-z/wget.profile (+4 -0)

📄 Description

My n-th attempt at implementing a fully sandboxed Node.js stack. I tried to accomodate earlier review comments/suggestions and only dropped nvm.profile as that cannot work as expected anyway (see specific commit comment for context). Although this could be regarded as a breaking change IMO it's better to remove it and motivate users to reflect on its peculiarity instead of suggesting a sense of security simply by having a profile.

Relates to:

#5050
#5051

Actionables:

close #4172 after merge (I think everything in there is incorporated here)
drop #5051 (older, not-that-well-informed attempt)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5058 **Author:** [@ghost](https://github.com/ghost) **Created:** 3/20/2022 **Status:** ✅ Merged **Merged:** 3/24/2022 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `nodejs-nvm` --- ### 📝 Commits (10+) - [`b1c2d2a`](https://github.com/netblue30/firejail/commit/b1c2d2a278efe3f91f955323a0c4da1281b36d08) allow-nodejs.inc: add nvm support - [`76c9668`](https://github.com/netblue30/firejail/commit/76c966877b31a11681027f872963883726cc4ae0) curl: add nvm support comment - [`8012fef`](https://github.com/netblue30/firejail/commit/8012fef42dbd0ef94d58b511fe2b334a2d3dedb2) nvm: remove profile - [`713249c`](https://github.com/netblue30/firejail/commit/713249c988d4b0c3c4754b2a1ac837e5d194a420) sha256sum: add nvm support comment - [`d96cf4c`](https://github.com/netblue30/firejail/commit/d96cf4c8c674716df7f0cbfbdcdf939080c7cd4e) tar: add nvm support comment - [`d09d1dc`](https://github.com/netblue30/firejail/commit/d09d1dc4a80d8dcdab53644a8fa22d7ee087d1a0) webstorm: fix ordering - [`114e4eb`](https://github.com/netblue30/firejail/commit/114e4eba27b3d92952d1dcb5d756b6f0c0bd0f02) webui-aria2: add nvm support - [`538050b`](https://github.com/netblue30/firejail/commit/538050b981892cf026db7be57087c3a099bf974d) wget: add nvm support comment - [`bc185a9`](https://github.com/netblue30/firejail/commit/bc185a94c839b04a18786acb285977821591fcb5) nodejs-common: add comment & minor hardening - [`ee8c57e`](https://github.com/netblue30/firejail/commit/ee8c57ee5fbb9c1dff42f48777b53cc1631ea114) Create node-gyp.profile ### 📊 Changes **11 files changed** (+53 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `etc/inc/allow-nodejs.inc` (+2 -0) 📝 `etc/profile-a-l/curl.profile` (+4 -0) 📝 `etc/profile-m-z/node-gyp.profile` (+3 -5) 📝 `etc/profile-m-z/nodejs-common.profile` (+10 -2) ➕ `etc/profile-m-z/npx.profile` (+11 -0) ➕ `etc/profile-m-z/semver.profile` (+11 -0) 📝 `etc/profile-m-z/sha256sum.profile` (+3 -0) 📝 `etc/profile-m-z/tar.profile` (+3 -0) 📝 `etc/profile-m-z/webstorm.profile` (+1 -1) 📝 `etc/profile-m-z/webui-aria2.profile` (+1 -0) 📝 `etc/profile-m-z/wget.profile` (+4 -0) </details> ### 📄 Description My n-th attempt at implementing a fully sandboxed Node.js stack. I tried to accomodate earlier review comments/suggestions and only dropped nvm.profile as that cannot work as expected anyway (see specific commit comment for context). Although this could be regarded as a breaking change IMO it's better to remove it and motivate users to reflect on its peculiarity instead of suggesting a sense of security simply by having a profile. Relates to: - #5050 - #5051 Actionables: - close #4172 after merge (I think everything in there is incorporated here) - drop #5051 (older, not-that-well-informed attempt) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:36:49 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:38:43 -06:00

[PR #5349] [MERGED] docs: Typo fixes #5454

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5349

No description provided.

Rows
Columns