[PR #4725] [MERGED] Keep some groups regardless of nogroups and restore nogroups on nvidia #5230

New issue

Closed

opened 2026-05-05 10:34:38 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:34:38 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/4725
Author: @kmk3
Created: 11/30/2021
Status: ✅ Merged
Merged: 11/30/2021
Merged by: @netblue30

Base: master ← Head: fix-groups-misc2

📝 Commits (4)

b828a90 Keep audio and video groups regardless of nogroups
a72f536 Keep render, lp, input and other groups regardless of nogroups
6ddedeb Make nogroups work on nvidia again
6521341 etc: Remove comments about nogroups and noroot on nvidia

📊 Changes

8 files changed (+88 additions, -30 deletions)

View changed files

📝 etc/profile-a-l/kodi.profile (+0 -1)
📝 etc/profile-m-z/mpsyt.profile (+0 -1)
📝 etc/profile-m-z/mpv.profile (+0 -1)
📝 etc/profile-m-z/steam.profile (+0 -1)
📝 src/firejail/firejail.h (+1 -0)
📝 src/firejail/main.c (+63 -19)
📝 src/firejail/profile.c (+2 -7)
📝 src/firejail/util.c (+22 -0)

📄 Description

$ git log --reverse --pretty='* %s' master..
* Keep audio and video groups regardless of nogroups
* Keep render, lp, input and other groups regardless of nogroups
* Make nogroups work on nvidia again
* etc: Remove comments about nogroups and noroot on nvidia

This should fix audio on seatd (#4531/#4603) and also make nogroups work
regardless of no3d on nvidia (#841/#3644).

Note: This is a continuation of #4632.

Note2: I have not tested this yet.

Cc: @crocket (from #4603) @hlein (from #4632)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/4725 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 11/30/2021 **Status:** ✅ Merged **Merged:** 11/30/2021 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `fix-groups-misc2` --- ### 📝 Commits (4) - [`b828a90`](https://github.com/netblue30/firejail/commit/b828a9047e7b8d153f8289bdd6e8039b6251fbeb) Keep audio and video groups regardless of nogroups - [`a72f536`](https://github.com/netblue30/firejail/commit/a72f53612299dec29a1c2b2049fcd8a60448b577) Keep render, lp, input and other groups regardless of nogroups - [`6ddedeb`](https://github.com/netblue30/firejail/commit/6ddedeba011fa32e005112cc4655bddbd7ce1e9f) Make nogroups work on nvidia again - [`6521341`](https://github.com/netblue30/firejail/commit/652134184291420191f5fb970c13e1f9ff1b9cc7) etc: Remove comments about nogroups and noroot on nvidia ### 📊 Changes **8 files changed** (+88 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `etc/profile-a-l/kodi.profile` (+0 -1) 📝 `etc/profile-m-z/mpsyt.profile` (+0 -1) 📝 `etc/profile-m-z/mpv.profile` (+0 -1) 📝 `etc/profile-m-z/steam.profile` (+0 -1) 📝 `src/firejail/firejail.h` (+1 -0) 📝 `src/firejail/main.c` (+63 -19) 📝 `src/firejail/profile.c` (+2 -7) 📝 `src/firejail/util.c` (+22 -0) </details> ### 📄 Description ```console $ git log --reverse --pretty='* %s' master.. * Keep audio and video groups regardless of nogroups * Keep render, lp, input and other groups regardless of nogroups * Make nogroups work on nvidia again * etc: Remove comments about nogroups and noroot on nvidia ``` This should fix audio on seatd (#4531/#4603) and also make `nogroups` work regardless of `no3d` on nvidia (#841/#3644). Note: This is a continuation of #4632. Note2: I have not tested this yet. Cc: @crocket (from #4603) @hlein (from #4632) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>