[PR #4712] [MERGED] Configure improvements2 #5228

New issue

Closed

opened 2026-05-05 10:34:37 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:34:37 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/4712
Author: @kmk3
Created: 11/24/2021
Status: ✅ Merged
Merged: 11/30/2021
Merged by: @netblue30

Base: master ← Head: configure-improvements2

📝 Commits (8)

3c6d523 configure.ac: Ensure whitespace after each comma
b20a1f3 configure*: Trim trailing spaces on var assignments
ef6df15 configure*: Fix wrong quote character in AC_MSG_ERROR
221c101 configure*: Add missing quotes to arguments
36058bc configure*: Move AC_SUBST calls to more obvious places
c84dc09 configure*: Remove redundant AC_SUBST calls near HAVE_LTS
6d42e13 build: Normalize HAVE_SUID
8344145 build: Normalize HAVE_CONTRIB_INSTALL

📊 Changes

4 files changed (+99 additions, -168 deletions)

View changed files

📝 Makefile.in (+1 -1)
📝 configure (+33 -67)
📝 configure.ac (+64 -95)
📝 src/common.mk.in (+1 -5)

📄 Description

This is mostly linting/cleanup. It undoes a few quirks to make configure.ac a
bit more consistent and easier to understand. See the commit messages for
details.

This is a continuation of #4316 and #4695.

Kind of relates to #4642.

Misc: I have a few more WIP configure-related changes (and some make-related
ones), but I need to test some of them and this branch is big enough.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/4712 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 11/24/2021 **Status:** ✅ Merged **Merged:** 11/30/2021 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `configure-improvements2` --- ### 📝 Commits (8) - [`3c6d523`](https://github.com/netblue30/firejail/commit/3c6d5232b880dbf474b9c567bb4530ce1842d612) configure.ac: Ensure whitespace after each comma - [`b20a1f3`](https://github.com/netblue30/firejail/commit/b20a1f3ebfff796d34055b51f09ee1224d3ea47c) configure*: Trim trailing spaces on var assignments - [`ef6df15`](https://github.com/netblue30/firejail/commit/ef6df15def7de0d6fe738e66d44ce99abc0d6527) configure*: Fix wrong quote character in AC_MSG_ERROR - [`221c101`](https://github.com/netblue30/firejail/commit/221c10177e64c7c53ee415bc1c015ecd17792451) configure*: Add missing quotes to arguments - [`36058bc`](https://github.com/netblue30/firejail/commit/36058bc54a059cd63bd4ce94b680f5f8c1441c92) configure*: Move AC_SUBST calls to more obvious places - [`c84dc09`](https://github.com/netblue30/firejail/commit/c84dc09257454075a8b7ce6e63581e0c7710ac8c) configure*: Remove redundant AC_SUBST calls near HAVE_LTS - [`6d42e13`](https://github.com/netblue30/firejail/commit/6d42e13a46b970c7197e1b70f6440ada1f8ec410) build: Normalize HAVE_SUID - [`8344145`](https://github.com/netblue30/firejail/commit/8344145f253d46eef22d958079d6e22a25dff24d) build: Normalize HAVE_CONTRIB_INSTALL ### 📊 Changes **4 files changed** (+99 additions, -168 deletions) <details> <summary>View changed files</summary> 📝 `Makefile.in` (+1 -1) 📝 `configure` (+33 -67) 📝 `configure.ac` (+64 -95) 📝 `src/common.mk.in` (+1 -5) </details> ### 📄 Description This is mostly linting/cleanup. It undoes a few quirks to make configure.ac a bit more consistent and easier to understand. See the commit messages for details. --- This is a continuation of #4316 and #4695. Kind of relates to #4642. Misc: I have a few more WIP configure-related changes (and some make-related ones), but I need to test some of them and this branch is big enough. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:34:37 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5228

No description provided.

Rows
Columns