[PR #4676] [MERGED] Make env/arg sanity check failure messages more useful #5220

New issue

Closed

opened 2026-05-05 10:34:26 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:34:26 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/4676
Author: @hlein
Created: 11/10/2021
Status: ✅ Merged
Merged: 11/11/2021
Merged by: @netblue30

Base: master ← Head: firejail_envchecks

📝 Commits (1)

0d06369 Make env/arg sanity check failure messages more useful

📊 Changes

2 files changed (+8 additions, -4 deletions)

View changed files

📝 src/firejail/main.c (+6 -4)
📝 src/firejail/run_symlink.c (+2 -0)

📄 Description

This change doesn't alter any checks, but it gives more specific
errors when a sanity check of env vars or argv does not pass, which
can point to limits to raise or at least give us better detailed bug
reports.

Signed-off-by: Hank Leininger hlein@korelogic.com
Bug: https://github.com/netblue30/firejail/issues/3678
Bug: https://github.com/netblue30/firejail/issues/3851
Bug: https://github.com/netblue30/firejail/issues/4633

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/4676 **Author:** [@hlein](https://github.com/hlein) **Created:** 11/10/2021 **Status:** ✅ Merged **Merged:** 11/11/2021 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `firejail_envchecks` --- ### 📝 Commits (1) - [`0d06369`](https://github.com/netblue30/firejail/commit/0d06369a808d184c112bf8cf3de7b4a1bd8ed412) Make env/arg sanity check failure messages more useful ### 📊 Changes **2 files changed** (+8 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/main.c` (+6 -4) 📝 `src/firejail/run_symlink.c` (+2 -0) </details> ### 📄 Description This change doesn't alter any checks, but it gives more specific errors when a sanity check of env vars or argv does not pass, which can point to limits to raise or at least give us better detailed bug reports. Signed-off-by: Hank Leininger <hlein@korelogic.com> Bug: https://github.com/netblue30/firejail/issues/3678 Bug: https://github.com/netblue30/firejail/issues/3851 Bug: https://github.com/netblue30/firejail/issues/4633 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:34:26 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5220

No description provided.

Rows
Columns