[PR #4632] [MERGED] Consider nosound and novideo when keeping groups & misc refactors #5214

New issue

Closed

opened 2026-05-05 10:34:21 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:34:21 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/4632
Author: @kmk3
Created: 10/22/2021
Status: ✅ Merged
Merged: 11/20/2021
Merged by: @smitsohu

Base: master ← Head: consider-nosound-novideo-groups

📝 Commits (4)

cc0a113 main.c: [ref] fix indentation and whitespace around group handling
25f7c7e util.c: [ref] move group find/copy into new functions
615ce15 util.c: check array size on copy_group_ifcont
ea564eb Consider nosound and novideo when keeping groups

📊 Changes

2 files changed (+124 additions, -92 deletions)

View changed files

📝 src/firejail/main.c (+82 -78)
📝 src/firejail/util.c (+42 -14)

📄 Description

Even when nogroups is not used, avoid keeping the audio and video
groups when nosound and novideo are used, respectively.

Based on @rusty-snake's suggestion:
https://github.com/netblue30/firejail/issues/4603#issuecomment-944046299

Relates to #4603.

Note: I haven't tested this.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/4632 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 10/22/2021 **Status:** ✅ Merged **Merged:** 11/20/2021 **Merged by:** [@smitsohu](https://github.com/smitsohu) **Base:** `master` ← **Head:** `consider-nosound-novideo-groups` --- ### 📝 Commits (4) - [`cc0a113`](https://github.com/netblue30/firejail/commit/cc0a113e982d2db70f42c15629d52c0149737d13) main.c: [ref] fix indentation and whitespace around group handling - [`25f7c7e`](https://github.com/netblue30/firejail/commit/25f7c7e0b7119dfd396077685695b646d02b1f9e) util.c: [ref] move group find/copy into new functions - [`615ce15`](https://github.com/netblue30/firejail/commit/615ce15623d152122f7bf8369d834c3561b1e468) util.c: check array size on copy_group_ifcont - [`ea564eb`](https://github.com/netblue30/firejail/commit/ea564eb74abaefd791a8c95d51e36c21e5fffcf9) Consider nosound and novideo when keeping groups ### 📊 Changes **2 files changed** (+124 additions, -92 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/main.c` (+82 -78) 📝 `src/firejail/util.c` (+42 -14) </details> ### 📄 Description Even when `nogroups` is not used, avoid keeping the audio and video groups when `nosound` and `novideo` are used, respectively. Based on @rusty-snake's suggestion: https://github.com/netblue30/firejail/issues/4603#issuecomment-944046299 Relates to #4603. --- Note: I haven't tested this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:34:21 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:37:49 -06:00

[PR #5216] [MERGED] test/fs: enable private-lib in firejail.config #5405

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5214

No description provided.

Rows
Columns