[PR #4593] [MERGED] Revert "allow/deny fbuilder" #5197

Closed
opened 2026-05-05 10:34:04 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/4593
Author: @kmk3
Created: 10/5/2021
Status: Merged
Merged: 10/9/2021
Merged by: @netblue30

Base: masterHead: revert-allow-deny-fbuilder


📝 Commits (2)

  • 5c39051 build_profile.c: fix typo of "begins"
  • a7e4b9b Revert "allow/deny fbuilder"

📊 Changes

4 files changed (+8 additions, -8 deletions)

View changed files

📝 src/fbuilder/build_fs.c (+4 -4)
📝 src/fbuilder/build_home.c (+2 -2)
📝 src/fbuilder/build_profile.c (+1 -1)
📝 test/utils/build.exp (+1 -1)

📄 Description

This reverts commit 4438f14f28.

Also, partially revert related commit e4307b409 ("fix whitelist/allow in
make test-utils") to keep the tests working.

The profiles are being generated using aliases, which are not used on
the profiles in the repository. So generate them using the normal
commands for consistency. See also commit dd13595b8 ("Revert
"allow/deny help and man pages"") / PR #4502.

Relates to #4410.

Misc: I noticed this on issue #4592.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/4593 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 10/5/2021 **Status:** ✅ Merged **Merged:** 10/9/2021 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `revert-allow-deny-fbuilder` --- ### 📝 Commits (2) - [`5c39051`](https://github.com/netblue30/firejail/commit/5c39051c2b07d6f4854eca69c37f95066d9fb10f) build_profile.c: fix typo of "begins" - [`a7e4b9b`](https://github.com/netblue30/firejail/commit/a7e4b9b9b20bc62985e03435e2eee41dd62e0318) Revert "allow/deny fbuilder" ### 📊 Changes **4 files changed** (+8 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/fbuilder/build_fs.c` (+4 -4) 📝 `src/fbuilder/build_home.c` (+2 -2) 📝 `src/fbuilder/build_profile.c` (+1 -1) 📝 `test/utils/build.exp` (+1 -1) </details> ### 📄 Description This reverts commit 4438f14f2892b5c88d158ae8fad0a80a2eebfd44. Also, partially revert related commit e4307b409 ("fix whitelist/allow in make test-utils") to keep the tests working. The profiles are being generated using aliases, which are not used on the profiles in the repository. So generate them using the normal commands for consistency. See also commit dd13595b8 ("Revert "allow/deny help and man pages"") / PR #4502. Relates to #4410. Misc: I noticed this on issue #4592. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 10:34:04 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5197
No description provided.