[PR #4389] [MERGED] Create profcleaner.sh #5141

New issue

Closed

opened 2026-05-05 10:33:02 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:33:02 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/4389
Author: @rusty-snake
Created: 7/7/2021
Status: ✅ Merged
Merged: 7/8/2021
Merged by: @netblue30

Base: master ← Head: profcleaner.sh

📝 Commits (2)

ed02ab5 Create profcleaner.sh
1bb3f61 profcleaner.sh: Rename --all to --system

📊 Changes

1 file changed (+45 additions, -0 deletions)

View changed files

➕ src/tools/profcleaner.sh (+45 -0)

📄 Description

profcleaner.c is just sed, I was wondering why we need C for that.

I must say here again that I do not like the blacklist/whitelist -> allow/deny change.

Having a command named allow that
- does not necessary allow access to a file is confusing (for new users)
- have site effects on other files is confusing (for new users)
The term "allow" is already used for allow-*.inc include, maybe we should renamed them to nodisable-*.inc/nodeny-*.inc
We still have whitelist-*.inc
We need some standardized terminology (commands vs. options vs. ...; does deny drop,block,disable a file / access to a file; ...)
We need to migrate comments in profiles as well.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/4389 **Author:** [@rusty-snake](https://github.com/rusty-snake) **Created:** 7/7/2021 **Status:** ✅ Merged **Merged:** 7/8/2021 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `profcleaner.sh` --- ### 📝 Commits (2) - [`ed02ab5`](https://github.com/netblue30/firejail/commit/ed02ab57b0e25047aca976b30ced64f94ff9c49a) Create profcleaner.sh - [`1bb3f61`](https://github.com/netblue30/firejail/commit/1bb3f617d99a7c13fe4a45797c6358efa4b23d96) profcleaner.sh: Rename --all to --system ### 📊 Changes **1 file changed** (+45 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `src/tools/profcleaner.sh` (+45 -0) </details> ### 📄 Description profcleaner.c is just sed, I was wondering why we need C for that. ------------ I must say here again that I do not like the blacklist/whitelist -> allow/deny change. 1. Having a command named `allow` that - does not necessary allow access to a file is confusing (for new users) - have site effects on other files is confusing (for new users) 2. The term "allow" is already used for `allow-*.inc` include, maybe we should renamed them to `nodisable-*.inc`/`nodeny-*.inc` 3. We still have `whitelist-*.inc` 4. We need some standardized terminology (commands vs. options vs. ...; does `deny` drop,block,disable a file / access to a file; ...) 5. We need to migrate comments in profiles as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:33:02 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:37:21 -06:00

[PR #5141] [MERGED] nvim: add XDG_STATE_HOME path #5378

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5141

No description provided.

Rows
Columns