github-starred/firejail

Fork 0

mirror of https://github.com/netblue30/firejail.git synced 2026-05-15 14:16:14 -06:00

[PR #4316] [MERGED] Configure improvements #5108

New issue

Closed

opened 2026-05-05 10:32:27 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:32:27 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/4316
Author: @kmk3
Created: 5/28/2021
Status: ✅ Merged
Merged: 5/29/2021
Merged by: @netblue30

Base: master ← Head: configure-improvements

📝 Commits (2)

bf81cd6 configure.ac: run autoupdate to fix autoconf warning
bfbed38 configure*: use cat instead of many echoes

📊 Changes

2 files changed (+90 additions, -86 deletions)

View changed files

📝 configure (+42 -41)
📝 configure.ac (+48 -45)

📄 Description

$ git log --reverse --pretty='%s%n%n%b%n-----%n' master..HEAD

configure.ac: run autoupdate to fix autoconf warning

This fixes the following warning:

$ autoconf
configure.ac:306: warning: AC_OUTPUT should be used without arguments.
configure.ac:306: You should run autoupdate.

Environment:

$ grep '^NAME' /etc/os-release
NAME="Artix Linux"
$ pacman -Q autoconf
autoconf 2.71-1

Though keep AC_PREREQ at 2.68 (released on 2010-09-23[1]), as version
2.71 (which autoupdate automatically bumps to) is rather recent
(released on 2021-01-28[2]) and the changes do not appear to require a
version bump, as on AC_INIT it only adds some quotes, and the rest of
the changes are consistent with the autoconf 2.68 manual. From Section
18.4, Obsolete Macros[3]:

— Macro: AC_OUTPUT ([file]..., [extra-cmds], [init-cmds])

The use of AC_OUTPUT with arguments is deprecated.  This obsoleted
interface is equivalent to:

          AC_CONFIG_FILES(file...)
          AC_CONFIG_COMMANDS([default],
                             extra-cmds, init-cmds)
          AC_OUTPUT

See AC_CONFIG_FILES, AC_CONFIG_COMMANDS, and AC_OUTPUT.

Note: The usage of the above format has been present since the inception
of configure.ac, on commit 137985136 ("Baseline firejail 0.9.28").

Misc: This is a continuation of #4293.

[1] https://lists.gnu.org/archive/html/info-gnu/2010-09/msg00013.html
[2] https://lists.gnu.org/archive/html/autoconf/2021-01/msg00126.html
[3] https://www.gnu.org/software/autoconf/manual/autoconf-2.68/html_node/Obsolete-Macros.html#index-AC_005fOUTPUT-2058

configure*: use cat instead of many echoes

For simplicity and increased portability.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/4316 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 5/28/2021 **Status:** ✅ Merged **Merged:** 5/29/2021 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `configure-improvements` --- ### 📝 Commits (2) - [`bf81cd6`](https://github.com/netblue30/firejail/commit/bf81cd6ad92cbccd1bcd71b428e724a1bb74d2e6) configure.ac: run autoupdate to fix autoconf warning - [`bfbed38`](https://github.com/netblue30/firejail/commit/bfbed383d8f1aa41f44d1f2716322ed810d294fe) configure*: use cat instead of many echoes ### 📊 Changes **2 files changed** (+90 additions, -86 deletions) <details> <summary>View changed files</summary> 📝 `configure` (+42 -41) 📝 `configure.ac` (+48 -45) </details> ### 📄 Description ```sh $ git log --reverse --pretty='%s%n%n%b%n-----%n' master..HEAD ``` configure.ac: run autoupdate to fix autoconf warning This fixes the following warning: $ autoconf configure.ac:306: warning: AC_OUTPUT should be used without arguments. configure.ac:306: You should run autoupdate. Environment: $ grep '^NAME' /etc/os-release NAME="Artix Linux" $ pacman -Q autoconf autoconf 2.71-1 Though keep `AC_PREREQ` at 2.68 (released on 2010-09-23[1]), as version 2.71 (which autoupdate automatically bumps to) is rather recent (released on 2021-01-28[2]) and the changes do not appear to require a version bump, as on `AC_INIT` it only adds some quotes, and the rest of the changes are consistent with the autoconf 2.68 manual. From Section 18.4, Obsolete Macros[3]: > — Macro: AC_OUTPUT ([file]..., [extra-cmds], [init-cmds]) > > The use of AC_OUTPUT with arguments is deprecated. This obsoleted > interface is equivalent to: > > AC_CONFIG_FILES(file...) > AC_CONFIG_COMMANDS([default], > extra-cmds, init-cmds) > AC_OUTPUT > > See AC_CONFIG_FILES, AC_CONFIG_COMMANDS, and AC_OUTPUT. Note: The usage of the above format has been present since the inception of configure.ac, on commit 137985136 ("Baseline firejail 0.9.28"). Misc: This is a continuation of #4293. [1] https://lists.gnu.org/archive/html/info-gnu/2010-09/msg00013.html [2] https://lists.gnu.org/archive/html/autoconf/2021-01/msg00126.html [3] https://www.gnu.org/software/autoconf/manual/autoconf-2.68/html_node/Obsolete-Macros.html#index-AC_005fOUTPUT-2058 ----- configure*: use cat instead of many echoes For simplicity and increased portability. ----- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:32:27 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:37:04 -06:00

[PR #5108] [MERGED] build(deps): bump actions/checkout from 3.0.0 to 3.0.1 #5362

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5108

No description provided.

Rows
Columns