[PR #4278] [MERGED] rename noautopulse to keep-config-pulse #5095

New issue

Closed

opened 2026-05-05 10:32:11 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:32:11 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/4278
Author: @kmk3
Created: 5/14/2021
Status: ✅ Merged
Merged: 5/16/2021
Merged by: @kmk3

Base: master ← Head: rename-noautopulse

📝 Commits (2)

5a61202 rename noautopulse to keep-config-pulse
b7015ed rename arg_noautopulse var to arg_keep_config_pulse

📊 Changes

9 files changed (+39 additions, -21 deletions)

View changed files

📝 contrib/vim/syntax/firejail.vim (+1 -1)
📝 src/firejail/firejail.h (+1 -1)
📝 src/firejail/main.c (+7 -4)
📝 src/firejail/profile.c (+7 -1)
📝 src/firejail/sandbox.c (+1 -1)
📝 src/firejail/usage.c (+2 -1)
📝 src/man/firejail-profile.txt (+6 -3)
📝 src/man/firejail.txt (+13 -9)
📝 src/zsh_completion/_firejail.in (+1 -0)

📄 Description

Changes:

add the keep-config-pulse option
make noautopulse an alias for keep-config-pulse
deprecate the noautopulse option
misc: fix indentation of --keep-dev-shm on src/firejail/usage.c

Even though noautopulse is not intended for hardening, it looks like it
is, because it starts with "no", just like no3d, noroot, etc). In fact,
it is the only "no" option that differs in such a way.

And it has been accidentally misused as such before; see PR #4269 and
commit e4beaeaa8 ("drop noautopulse from agetpkg").

So effectively rename it to keep-config-pulse in order to avoid
confusion. This is similar to the keep-var-tmp and keep-dev-shm
options, which are used to "leave a path alone", just like noautopulse.

Note: The changes on this patch are based on the ones from commit
617ff40c9 ("add --noautopulse arg for complex pulse setups") / PR #1854.

See #4269 for the discussion.

Cc: @vermeeren (as the author of #1854)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/4278 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 5/14/2021 **Status:** ✅ Merged **Merged:** 5/16/2021 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `rename-noautopulse` --- ### 📝 Commits (2) - [`5a61202`](https://github.com/netblue30/firejail/commit/5a612029b6c88000eba3b1195eedb7169553b7fa) rename noautopulse to keep-config-pulse - [`b7015ed`](https://github.com/netblue30/firejail/commit/b7015edb02e06e26700fd23722b3c47b26063d2b) rename arg_noautopulse var to arg_keep_config_pulse ### 📊 Changes **9 files changed** (+39 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `contrib/vim/syntax/firejail.vim` (+1 -1) 📝 `src/firejail/firejail.h` (+1 -1) 📝 `src/firejail/main.c` (+7 -4) 📝 `src/firejail/profile.c` (+7 -1) 📝 `src/firejail/sandbox.c` (+1 -1) 📝 `src/firejail/usage.c` (+2 -1) 📝 `src/man/firejail-profile.txt` (+6 -3) 📝 `src/man/firejail.txt` (+13 -9) 📝 `src/zsh_completion/_firejail.in` (+1 -0) </details> ### 📄 Description Changes: * add the keep-config-pulse option * make noautopulse an alias for keep-config-pulse * deprecate the noautopulse option * misc: fix indentation of --keep-dev-shm on src/firejail/usage.c Even though noautopulse is not intended for hardening, it looks like it is, because it starts with "no", just like no3d, noroot, etc). In fact, it is the only "no" option that differs in such a way. And it has been accidentally misused as such before; see PR #4269 and commit e4beaeaa8 ("drop noautopulse from agetpkg"). So effectively rename it to keep-config-pulse in order to avoid confusion. This is similar to the keep-var-tmp and keep-dev-shm options, which are used to "leave a path alone", just like noautopulse. Note: The changes on this patch are based on the ones from commit 617ff40c9 ("add --noautopulse arg for complex pulse setups") / PR #1854. See #4269 for the discussion. Cc: @vermeeren (as the author of #1854) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:32:11 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5095

No description provided.

Rows
Columns