[PR #4255] [MERGED] Node.js stack refactoring #5084

New issue

Closed

opened 2026-05-05 10:32:00 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:32:00 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/4255
Author: @ghost
Created: 5/7/2021
Status: ✅ Merged
Merged: 5/8/2021
Merged by: @undefined

Base: master ← Head: node-stack

📝 Commits (10+)

5a86de6 Create node.profile
000a3f6 Create node-gyp.profile
65ce781 refactor npm as redirect
c493bad Create npx.profile
65d01b9 Create nvm.profile
b56cb36 Create semver.profile
33905d8 refactor yarn as redirect
be51cf3 collect node.js stack configuration in common profile
2666c7a add ~/.nvm to node section
f6ef2b2 account for node-gyp python dependency

📊 Changes

10 files changed (+77 additions, -43 deletions)

View changed files

📝 README.md (+1 -1)
📝 etc/inc/allow-common-devel.inc (+1 -0)
📝 etc/inc/allow-nodejs.inc (+4 -0)
📝 etc/inc/disable-common.inc (+1 -0)
📝 etc/inc/disable-programs.inc (+1 -0)
➕ etc/profile-m-z/node.profile (+11 -0)
📝 etc/profile-m-z/nodejs-common.profile (+45 -4)
📝 etc/profile-m-z/npm.profile (+0 -18)
➕ etc/profile-m-z/nvm.profile (+13 -0)
📝 etc/profile-m-z/yarn.profile (+0 -20)

📄 Description

An attempt to bring some sanity to our node.js related profiles. Based on info gathered from:

our existing profiles
https://wiki.archlinux.org/title/Node.js
https://github.com/nvm-sh/nvm/blob/master/README.md

~~Not being a Node developer I'm marking this as WIP for now.~~ I've been testing this, but the node stack still has many dark spots for me to unravel. Would be great if this could be more thoroughly tested. Open to all suggestions, input etcetera.

IMPORTANT NOTE: none of the Node.js stack profiles are in firecfg. It is up to the user to create the necessary scripts/symlinks to sandbox the following commands:

/usr/bin/node
/usr/bin/npm
/usr/bin/nvm
/usr/bin/yarn

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/4255 **Author:** [@ghost](https://github.com/ghost) **Created:** 5/7/2021 **Status:** ✅ Merged **Merged:** 5/8/2021 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `node-stack` --- ### 📝 Commits (10+) - [`5a86de6`](https://github.com/netblue30/firejail/commit/5a86de660852543576d78fc79aca15a9b3e07372) Create node.profile - [`000a3f6`](https://github.com/netblue30/firejail/commit/000a3f64f6a4bb7d2d14a1e77f27cef1a5fac092) Create node-gyp.profile - [`65ce781`](https://github.com/netblue30/firejail/commit/65ce781f60b7fc9a1f1275155634ee744a5aac06) refactor npm as redirect - [`c493bad`](https://github.com/netblue30/firejail/commit/c493bad1d95053ff1ec9b9febc29733ed7534b64) Create npx.profile - [`65d01b9`](https://github.com/netblue30/firejail/commit/65d01b9323250a615a8ab228b383f5ae58675b0d) Create nvm.profile - [`b56cb36`](https://github.com/netblue30/firejail/commit/b56cb36bb295c5bc9ef331652f4eb9f10e385888) Create semver.profile - [`33905d8`](https://github.com/netblue30/firejail/commit/33905d8af92a37cbffd5b72348048f00c5a9150d) refactor yarn as redirect - [`be51cf3`](https://github.com/netblue30/firejail/commit/be51cf361bef6fbcfe4b5a30a8594f44f6f00b34) collect node.js stack configuration in common profile - [`2666c7a`](https://github.com/netblue30/firejail/commit/2666c7a67bbcdf8047a6b7886bf9829d3eb2bb8a) add ~/.nvm to node section - [`f6ef2b2`](https://github.com/netblue30/firejail/commit/f6ef2b2fe58d374338a5e5f372ae1970c1a3fb5b) account for node-gyp python dependency ### 📊 Changes **10 files changed** (+77 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -1) 📝 `etc/inc/allow-common-devel.inc` (+1 -0) 📝 `etc/inc/allow-nodejs.inc` (+4 -0) 📝 `etc/inc/disable-common.inc` (+1 -0) 📝 `etc/inc/disable-programs.inc` (+1 -0) ➕ `etc/profile-m-z/node.profile` (+11 -0) 📝 `etc/profile-m-z/nodejs-common.profile` (+45 -4) 📝 `etc/profile-m-z/npm.profile` (+0 -18) ➕ `etc/profile-m-z/nvm.profile` (+13 -0) 📝 `etc/profile-m-z/yarn.profile` (+0 -20) </details> ### 📄 Description An attempt to bring some sanity to our node.js related profiles. Based on info gathered from: - our existing profiles - https://wiki.archlinux.org/title/Node.js - https://github.com/nvm-sh/nvm/blob/master/README.md ~~Not being a Node developer I'm marking this as WIP for now.~~ I've been testing this, but the node stack still has many dark spots for me to unravel. Would be great if this could be more thoroughly tested. Open to all suggestions, input etcetera. IMPORTANT NOTE: none of the Node.js stack profiles are in firecfg. It is up to the user to create the necessary scripts/symlinks to sandbox the following commands: - /usr/bin/node - /usr/bin/npm - /usr/bin/nvm - /usr/bin/yarn --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:32:00 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:36:55 -06:00

[PR #5084] [MERGED] man: typo fixes #5356

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5084

No description provided.

Rows
Columns